Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not imported Source / Element classes are not registered #343

Open
mhordynski opened this issue Feb 11, 2025 · 2 comments
Open

fix: not imported Source / Element classes are not registered #343

mhordynski opened this issue Feb 11, 2025 · 2 comments

Comments

@mhordynski
Copy link
Member

Source subclasses are automatically registered upon import when declared. This enables us to automatically map them from JSON to the correct subclass or use a URI path to determine which implementation should be used (for example, gcs://something routes to GCSSource).

Currently, if a given implementation is not imported, this feature does not work. The goal of this task is to provide an explicit method to register source classes.

@mhordynski mhordynski self-assigned this Feb 11, 2025
@mhordynski mhordynski moved this to Backlog in ragbits Feb 11, 2025
@mhordynski
Copy link
Member Author

On core level of our configuration in pyproject.toml we should add new section, where we specify module paths what should be imported via ragbits.

@mhordynski mhordynski moved this from Backlog to Ready in ragbits Feb 11, 2025
@mhordynski mhordynski removed their assignment Feb 11, 2025
@mhordynski mhordynski added this to the 0 / Maintenance milestone Feb 12, 2025
@mhordynski
Copy link
Member Author

Same mechanism will work for Element objects - need to document that.

@mhordynski mhordynski changed the title fix: not imported Source classes are not registered fix: not imported Source / Element classes are not registered Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

1 participant