Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better batching in ingest method #348

Open
mhordynski opened this issue Feb 11, 2025 · 0 comments
Open

feat: better batching in ingest method #348

mhordynski opened this issue Feb 11, 2025 · 0 comments
Assignees
Labels
feature New feature or request

Comments

@mhordynski
Copy link
Member

mhordynski commented Feb 11, 2025

Feature description

Right now ingest method flow looks like this:

  • document processing(chunking) is controlled by ProcessingExecutionStrategy
  • All elements are grouped together
  • All embeddings are calculated at once

We should also batch requests to embedding model and vector database. One way is to move embedding&inserting into ProcessingExecutionStrategy.

For errors we should decide how to handle failed documents, for example create a default implementation gathering all failed documents into a list. User should be able to create custom error handling strategy.

Motivation

Current behaviour causes problems with rate limits / memory usage / too big requests to embedding models.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant