Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

computeGCBias.py can't handle --blackListFileName #334

Closed
kashyapchhatbar opened this issue Apr 6, 2016 · 5 comments
Closed

computeGCBias.py can't handle --blackListFileName #334

kashyapchhatbar opened this issue Apr 6, 2016 · 5 comments

Comments

@kashyapchhatbar
Copy link

The rest of the tools are fine with it, however computeGCBias is not considering --blackListFileName properly

Here's the error

~ @
❯ computeGCBias -b bowtie_sorted/Input_WT_rep1.bam -bl mm9-blacklist.bed -freq freq.txt --effectiveGenomeSize 2150570000 -g mm9.2bit -l 120
Traceback (most recent call last):
  File "/usr/bin/computeGCBias", line 7, in <module>
    main()
  File "/usr/lib/python2.7/site-packages/deeptools/computeGCBias.py", line 623, in main
    filter_out_file = args.BlackListFileName
AttributeError: 'Namespace' object has no attribute 'BlackListFileName'

It's showing the error here. I think it's a typo for blackListFileName argument and also since the new implementation of blacklist file, filterOut argument is not required.

Huge thanks for the awesome tool 👍

@dpryan79
Copy link
Collaborator

dpryan79 commented Apr 8, 2016

I've merged the fix for this. I'll try to coordinate getting version 2.2.3 on pypi/bioconda/Galaxy today.

@dpryan79
Copy link
Collaborator

dpryan79 commented Apr 8, 2016

Ping @bgruening @fidelram

@bgruening
Copy link
Member

Okidoki!

@kashyapchhatbar
Copy link
Author

Confirming that the fix is working! Thanks :)

@dpryan79
Copy link
Collaborator

Great, thanks for letting us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants