Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--maxThreshold only affects heatmaps put not profiles. #702

Closed
dpryan79 opened this issue May 5, 2018 · 1 comment
Closed

--maxThreshold only affects heatmaps put not profiles. #702

dpryan79 opened this issue May 5, 2018 · 1 comment

Comments

@dpryan79
Copy link
Collaborator

dpryan79 commented May 5, 2018

Realistically, the profile should be an accurate summarization of the underlying matrix and heatmap. So if we exclude rows from the heatmaps due to --maxThreshold or --minThreshold then they should be excluded from the profiles as well. These should also not affect things like cluster, so we might as well filter rows immediately after loading the matrix so every other step will definitely fit. The only difficulty to this will be ensuring the group bounds are maintained. I think the proper implementation will be some sort of valueFilter function in computeMatrixOperations with min and max options. The matrix load function can then simply call that.

@dpryan79 dpryan79 changed the title --maxThreshold on affects heatmaps put not profiles. --maxThreshold only affects heatmaps put not profiles. May 5, 2018
@dpryan79
Copy link
Collaborator Author

This is now in develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant