Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace zarf data injection #145

Merged
merged 9 commits into from
Jul 12, 2024
Merged

feat: replace zarf data injection #145

merged 9 commits into from
Jul 12, 2024

Conversation

blancharda
Copy link
Contributor

Removing zarfception and data injection in favor of a simpler kubectl cp

delete delete delete

@blancharda
Copy link
Contributor Author

Tested on dev in the following scenarios:

  • first time applying a jar
  • repeat attempts at applying the same jar
  • running with no local jars

anthonywendt
anthonywendt approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@anthonywendt anthonywendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blancharda blancharda merged commit 5f9be14 into main Jul 12, 2024
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
Merged
@anthonywendt anthonywendt deleted the feature/replace-injection branch July 25, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonywendt anthonywendt anthonywendt approved these changes

@jacobbmay jacobbmay Awaiting requested review from jacobbmay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blancharda @anthonywendt