Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: UDS state and intelligent removes #614

Closed
UncleGedd opened this issue May 15, 2024 · 6 comments
Closed

engine: UDS state and intelligent removes #614

UncleGedd opened this issue May 15, 2024 · 6 comments
Assignees
Labels
engine relates to UDS Engine enhancement New feature or request

Comments

@UncleGedd
Copy link
Collaborator

UncleGedd commented May 15, 2024

Is your feature request related to a problem? Please describe

Intelligent package handling on bundle upgrades

Describe the solution you'd like

  • Given a bundle has been deployed successfully once, and now I'm upgrading
  • When I upgrade and a package has been removed from the uds-bundle.yaml
  • Then I want the option to remove the removed package from my cluster

Additional context

@UncleGedd UncleGedd added enhancement New feature or request engine relates to UDS Engine labels May 15, 2024
@UncleGedd UncleGedd changed the title Engine: UDS state and intelligent removes engine: UDS state and intelligent removes May 15, 2024
@mjnagel
Copy link
Collaborator

mjnagel commented Jun 20, 2024

I suspect the first part of this is likely keeping track of bundles in a secret (similar to how zarf stores package state in a secret)? If the "bundle state secret" keeps track of zarf packages (at a minimum) then on an "upgrade" we would know which packages were removed/added. I think there's probably another layer that zarf might need to handle (component removals) but handling bundle state is a good first thing to tackle.

@MxNxPx
Copy link

MxNxPx commented Jul 19, 2024

@UncleGedd we definitely have hit this problem with uds-infrastructure and would benefit from solving.
we needed to remove a zarf package that was defined in a bundle (example: a LFAI model gets swapped out), and ended up manually connecting to the cluster and doing a zarf package remove.

@UncleGedd
Copy link
Collaborator Author

@decleaver is working on a design doc for this feature over in #834

@UncleGedd UncleGedd self-assigned this Aug 16, 2024
@UncleGedd UncleGedd added this to the v0.15.0 milestone Aug 16, 2024
This was referenced Aug 19, 2024
@UncleGedd
Copy link
Collaborator Author

Need to figure out vision for UDS state with @jeff-mccoy

@UncleGedd UncleGedd removed the blocked label Aug 28, 2024
@UncleGedd
Copy link
Collaborator Author

Spoke with Jeff and agreed to implement a minimal version of UDS state

@UncleGedd UncleGedd modified the milestones: v0.15.0, v0.16.0 Sep 9, 2024
@UncleGedd UncleGedd removed this from the v0.16.0 milestone Sep 16, 2024
@catsby
Copy link
Collaborator

catsby commented Oct 9, 2024

Update: we're evaluating options here, so I'm going to close this issue at this time.

@catsby catsby closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine relates to UDS Engine enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants