fix: revert "chore: support deselection of metrics-server" #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 289a0fe.
TristanHoladay
previously approved these changes
Feb 21, 2024
mjnagel
pushed a commit
that referenced
this pull request
Feb 21, 2024
🤖 I have created a release *beep* *boop* --- ## [0.13.1](v0.13.0...v0.13.1) (2024-02-21) ### Bug Fixes * revert "chore: support deselection of metrics-server" ([#196](#196)) ([25a408d](25a408d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny
pushed a commit
to owen-grady/uds-core-slim-dev
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.13.1](defenseunicorns/uds-core@v0.13.0...v0.13.1) (2024-02-21) ### Bug Fixes * revert "chore: support deselection of metrics-server" ([#196](defenseunicorns/uds-core#196)) ([25a408d](defenseunicorns/uds-core@25a408d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #193
Reverting this due to zarf-dev/zarf#2320
Resolves #195
Also added a temporary task addition to make sure that tasks can run and succeed.