feat: expose tls certs as UDS bundle variables #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachariahmiller
approved these changes
Nov 19, 2023
Yeah agreed, we're doing it at this level for now until we settle on the final style to push down to zarf. |
jeff-mccoy
pushed a commit
that referenced
this pull request
Nov 19, 2023
🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.1...v0.5.0) (2023-11-19) ### Features * expose tls certs as UDS bundle variables ([#48](#48)) ([c1f8286](c1f8286)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny
pushed a commit
to owen-grady/uds-core-slim-dev
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.0](defenseunicorns/uds-core@v0.4.1...v0.5.0) (2023-11-19) ### Features * expose tls certs as UDS bundle variables ([#48](defenseunicorns/uds-core#48)) ([c1f8286](defenseunicorns/uds-core@c1f8286)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR leverages the new UDS Helm Variables mapping introduce in UDS CLI v0.3.0. While this is currently at the bundle-level, this should eventually make it down to the Zarf level. However, for UDS deployers, the change will be transparent.
Type of change
Checklist before merging