-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add UDS Operator and consolidate UDS Policies #66
Conversation
What is the plan for the lifecycle of the CR? I see you set ownerReferences, which should cleanup created resources in the namespace on deletion. But what about updates? The scenario I'm most worried about is this doesn't handle deletion on CR change. If you change the network config (but don't delete the CR), some of the old NetworkPolicies will need to be deleted. You could consider an approach like Flux's kustomize-controller: they store a list of all the created resources in |
feedback addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at this point. I did modify the loki policies and add a Package
CR for prometheus-stack so might be good to get @mikevanhemert / @zachariahmiller to confirm those pieces at least as a validation I didn't mess things up too much.
🤖 I have created a release *beep* *boop* --- ## [0.8.0](v0.7.4...v0.8.0) (2024-01-16) ### Features * add UDS Operator and consolidate UDS Policies ([#66](#66)) ([395c1c4](395c1c4)) ### Miscellaneous * adding unit test for registerExemptions() ([#105](#105)) ([5e71fcf](5e71fcf)) * **deps:** update pepr to v0.22.2 ([#104](#104)) ([0555353](0555353)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.8.0](defenseunicorns/uds-core@v0.7.4...v0.8.0) (2024-01-16) ### Features * add UDS Operator and consolidate UDS Policies ([#66](defenseunicorns/uds-core#66)) ([395c1c4](defenseunicorns/uds-core@395c1c4)) ### Miscellaneous * adding unit test for registerExemptions() ([#105](defenseunicorns/uds-core#105)) ([5e71fcf](defenseunicorns/uds-core@5e71fcf)) * **deps:** update pepr to v0.22.2 ([#104](defenseunicorns/uds-core#104)) ([0555353](defenseunicorns/uds-core@0555353)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Description
This PR consolidates all Pepr capabilities into the folder
src/pepr
. This PR also introduces the UDS Operator, which manages a new CRDpackages
under the groupuds.dev/v1alpha1
.The UDS Operator manages the lifecycle of UDS Package CRs and their corresponding resources (e.g. NetworkPolicies, Istio VirtualServices, etc.). The operator uses Pepr to bind the watch operations to the enque and reconciler. The operator is responsible for:
KubeAPI
andCloudMetadata
to make policies more DRY and provide dynamic bindings where a static definition is not possibleKey Files and Folders