fix: wait on istio proxies #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-mccoy
approved these changes
Jan 9, 2024
jeff-mccoy
pushed a commit
that referenced
this pull request
Jan 10, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.2](v0.7.1...v0.7.2) (2024-01-09) ### Bug Fixes * wait on istio proxies ([#87](#87)) ([51cd5a0](51cd5a0)) ### Miscellaneous * kick off ci ([1afc3a4](1afc3a4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny
pushed a commit
to owen-grady/uds-core-slim-dev
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.2](defenseunicorns/uds-core@v0.7.1...v0.7.2) (2024-01-09) ### Bug Fixes * wait on istio proxies ([#87](defenseunicorns/uds-core#87)) ([51cd5a0](defenseunicorns/uds-core@51cd5a0)) ### Miscellaneous * kick off ci ([1afc3a4](defenseunicorns/uds-core@1afc3a4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This seems to be a common default across most istio installs (including Big Bang). The effect is just to make sure that the main "app" containers don't start until proxies are up.
Related Issue
Fixes #69
Type of change
Checklist before merging