feat: mocks can be deployed with libs #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wei3erHase
reviewed
Sep 7, 2021
Comment on lines
+10
to
+18
| it('should be able to use libraries', async () => { | ||
| const testLibrary = await (await ethers.getContractFactory('TestLibrary')).deploy(); | ||
| const librarian = await ( | ||
| await smock.mock<Librarian__factory>('Librarian', { | ||
| libraries: { | ||
| TestLibrary: testLibrary.address, | ||
| }, | ||
| }) | ||
| ).deploy(); |
wei3erHase
reviewed
Sep 7, 2021
|
|
||
| chai.use(smock.matchers); | ||
|
|
||
| describe.only('Mock: Initialization', () => { |
There was a problem hiding this comment.
Solved, forced push commit
wei3erHase
approved these changes
Sep 7, 2021
0xGorilla
force-pushed
the
feat/lib-deployment
branch
from
14daa74
to
d84af92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mocks now receive the same arguments as
ethers.getContractFactoryand it forwards them to the real function