Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deriving reagent dependency from re-frame? #24

Closed
shen-tian opened this issue Aug 29, 2018 · 1 comment
Closed

Deriving reagent dependency from re-frame? #24

shen-tian opened this issue Aug 29, 2018 · 1 comment

Comments

@shen-tian
Copy link
Contributor

Noticed this by accident that the project I'm working on is using React 16 rather than 15.

lein deps :tree showed this was being pulled in via reagent 0.8 via re-frame-firebase. Latest re-frame itself is using reagent 0.7.

Suggestion: drop the explicit reagent dependency unless there's a good reason to need the newest version?

@deg
Copy link
Owner

deg commented Aug 29, 2018

This makes sense. I don't remember why I had originally added the explicit dependency on reagent, but it does not seem like it should be needed.

If you have time to make the change, please verify that it doesn't break examples/firestore or anything else obvious, then send me a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants