Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

length_1200 = 1 for all rows when buffer >= 800 #7

Closed
erikarasnick opened this issue Jan 19, 2023 · 2 comments · Fixed by #8
Closed

length_1200 = 1 for all rows when buffer >= 800 #7

erikarasnick opened this issue Jan 19, 2023 · 2 comments · Fixed by #8

Comments

@erikarasnick
Copy link
Member

Kelly sent me an example file and I was able to reproduce the error. Values look normal for 400 m and 700 m buffer, but length_1200 is 1 for all rows with 700 m and 800 m buffers.
@erikarasnick
Copy link
Member Author

add test for larger buffers to GHA

@erikarasnick
Copy link
Member Author

The logic I wrote for when buffers have zero road length vs non zero road length in incorrect, causing all lengths to be 1 when every row has a buffer with non-zero road length.
Screen Shot 2023-01-19 at 5 26 20 PM

PR with fix to come...

@erikarasnick erikarasnick linked a pull request Jan 20, 2023 that will close this issue
fix zero vs non-zero length logic; round dist to nearest #8
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix zero vs non-zero length logic; round dist to nearest degauss-org/roads
1 participant
@erikarasnick