Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write unit tests for the code herein #57

Open
arschles opened this issue Apr 13, 2016 · 7 comments
Open

Write unit tests for the code herein #57

arschles opened this issue Apr 13, 2016 · 7 comments

Comments

@arschles
Copy link
Member

Important sections of this codebase are protected by sync.Mutexes or sync.RWMutexes, so special attention should be paid to writing concurrent tests (so that we can run go test -race)

@arschles arschles added the bug label Apr 13, 2016
@arschles arschles added this to the v2.0-beta3 milestone Apr 13, 2016
@arschles
Copy link
Member Author

Punting to beta4

@arschles arschles modified the milestones: v2.0-beta4, v2.0-beta3 Apr 21, 2016
@arschles
Copy link
Member Author

arschles commented May 9, 2016

I'm moving this to RC1. Also note that I haven't looked at the state of the code or amount of coverage in unit tests yet. I just noticed that there are not many...

@arschles arschles modified the milestones: v2.0-rc1, v2.0-beta4 May 9, 2016
@bacongobbler
Copy link
Member

reclassifying as tests rather than a bug

@bacongobbler
Copy link
Member

@jchauncey would you be willing to take a crack at this or shall we punt to post-2.0?

@jchauncey
Copy link
Member

i have tests in stdout-metrics that does a lot of what we want to test in logger i just need time to port them. but yeah we should just wait

@bacongobbler bacongobbler removed this from the v2.0-rc1 milestone May 19, 2016
@Joshua-Anderson
Copy link

@jchauncey Were said unit tests ever written? It looks like the logger had 70% coverage, though with recent refactors has fallen to 40%

@Cryptophobia
Copy link

This issue was moved to teamhephy/logger#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants