Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When connected from an offliner-client, make offliner to dispatch the activationPending event if proceeds. #8

Open
delapuente opened this issue Nov 4, 2015 · 0 comments · May be fixed by #13

Comments

@delapuente
Copy link
Owner

If for some reason, in the last activationPending event, the new version did not get activated, the event won't be dispatched again unless the developer makes a explicit call to offlinerClient.update().

This could be problematic in the scenario where the worker file is modified at byte level and the strategy is to update on modification only. To do that, the strategy must check if isCalledFromInstall flag is set and if it is, return true. When calling update() from the offline client, the flag is not set and it's not possible to distinguish there were a byte level change.

Of course, the strategy could set a custom flag for it and keep track of it but as there is no way to for the update strategy to be notified when an activation is done, this flag could not be unset safely.

Allowing offliner to dispatch the activationPending event in case of a client connecting to it sounds totally reasonable and cover most of the cases.

@delapuente delapuente linked a pull request Nov 5, 2015 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant