Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: make gosec is erroring out - Repos PowerMax,PowerStore,PowerScale (gosec is installed) #1053

Closed
boyamurthy opened this issue Nov 24, 2023 · 0 comments
Labels
area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax area/csi-powerscale Issue pertains to the CSI Driver for Dell EMC PowerScale area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore type/bug Something isn't working. This is the default label associated with a bug issue.
Milestone

Comments

@boyamurthy
Copy link
Contributor

Bug Description

make gosec is failing with error
[root@master-1-ycOCQw49jiTxa csi-powermax]# make gosec
gosec -quiet -log gosec.log -out=gosecresults.csv -fmt=csv ./...
make: gosec: Command not found
make: *** [Makefile:79: gosec] Error 127

Logs

It is installed in the path of GOBIN

so tried changing it to the below code in Makefile

installgosec:
go install github.com/securego/gosec/v2/cmd/gosec@latest
gosec: installgosec
ifeq (, $(shell which gosec))
$(GOBIN)/gosec -quiet -log gosec.log -out=gosecresults.csv -fmt=csv ./...
else
$(shell which gosec) -quiet -log gosec.log -out=gosecresults.csv -fmt=csv ./...
endif*

Though this command is working and giving the csv output file, it is erroring out

[root@master-1-ycOCQw49jiTxa csi-powermax]# make gosec
which: no gosec in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/usr/local/go/bin:/root/bin)
go install github.com/securego/gosec/v2/cmd/gosec@latest
/root/go/bin/gosec -quiet -log gosec.log -out=gosecresults.csv -fmt=csv ./...
make: *** [Makefile:81: gosec] Error 1

Screenshots

No response

Additional Environment Information

No response

Steps to Reproduce

Execute "make gosec" from driver repo .

Expected Behavior

make gosec should be executed successfully .

CSM Driver(s)

csi drivers .

Installation Type

No response

Container Storage Modules Enabled

No response

Container Orchestrator

all

Operating System

all

@boyamurthy boyamurthy added type/bug Something isn't working. This is the default label associated with a bug issue. area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore area/csi-powerscale Issue pertains to the CSI Driver for Dell EMC PowerScale area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax labels Nov 24, 2023
@boyamurthy boyamurthy added this to the v1.9.0 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax area/csi-powerscale Issue pertains to the CSI Driver for Dell EMC PowerScale area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore type/bug Something isn't working. This is the default label associated with a bug issue.
Projects
None yet
Development

No branches or pull requests

2 participants