Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Make files in repositories build invalid images #1372

Closed
shanmydell opened this issue Jul 8, 2024 · 2 comments
Closed

[BUG]: Make files in repositories build invalid images #1372

shanmydell opened this issue Jul 8, 2024 · 2 comments
Assignees
Labels
area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax type/bug Something isn't working. This is the default label associated with a bug issue.
Milestone

Comments

@shanmydell
Copy link
Collaborator

shanmydell commented Jul 8, 2024

Bug Description

Running 'make docker' will build images using rockylinux:9 as the base image rather than the UBI micro image.  Therefore, building images using 'make docker' will produce an invalid image.

The make files across all of CSM should be updated to point to build.sh

For CSM PowerMax, image build automation that is used to build and push the images to DockerHub is using build.sh so there is no impact to how we build/push our nightly images or release images.

The fix here is to update the instructions in the README file to use build.sh.

Steps to Reproduce

See instructions provided to execute 'make docker' here: https://github.com/dell/csi-powermax/blob/main/Makefile

Expected Behavior

Instructions in the README file should provide manual build instructions that build a valid image - one with UBI micro as the base image.

CSM Driver(s)

CSI PowerMax
Possibly Others

@shanmydell shanmydell added needs-triage Issue requires triage. type/bug Something isn't working. This is the default label associated with a bug issue. and removed needs-triage Issue requires triage. labels Jul 8, 2024
@shanmydell
Copy link
Collaborator Author

/sync

@csmbot
Copy link
Collaborator

csmbot commented Jul 8, 2024

link: 26087

@gallacher gallacher changed the title [BUG]: Make build of csi-powermax is not building the correct image, it is building developer kit with rocky linux [BUG]: Repository README files provide instructions that build invalid images Jul 10, 2024
@gallacher gallacher changed the title [BUG]: Repository README files provide instructions that build invalid images [BUG]: Make files in repositories build invalid images Jul 10, 2024
@bjiang27 bjiang27 self-assigned this Jul 12, 2024
@bjiang27 bjiang27 added this to the v1.11.0 milestone Jul 12, 2024
@bjiang27 bjiang27 added the area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax type/bug Something isn't working. This is the default label associated with a bug issue.
Projects
None yet
Development

No branches or pull requests

3 participants