[BUG]: Replication install using Operator does not work

[donatwork]

Bug Description

It is not possible to install CSM Replication in the single stretched cluster mode. The parameter TARGET_CLUSTER_IDS requires at least one value but in the repctl instructions the target cluster is replaced with "self". This does not work when using Operator.

    - name: dell-replication-controller-manager
       # image: Defines controller image. This shouldn't be changed
       # Allowed values: string
       image: dellemc/dell-replication-controller:v1.4.0
       envs:
         # TARGET_CLUSTERS_IDS: comma separated list of clusters id of the targets clusters. DO NOT include the source(wherever CSM Operator is deployed) cluster id
         # Allowed values: string
         - name: "TARGET_CLUSTERS_IDS"
           value: "self"

Also tried with an empty value "" and also saw errors.

Another issue I have with the documentation is that the instructiosn (https://dell.github.io/csm-docs/docs/deployment/csmoperator/modules/replication/#prerequisite) states to follow all of the steps in the install using repctl section but those instructions install an instance of the dell-replication-controller-manager. Why is the Operator installation also installing the same pod?

Logs

Event(v1.ObjectReference{Kind:"ContainerStorageModule", Namespace:"isilon", Name:"isilon", UID:"44538889-bfe8-4dae-aae1-63959c9d73de", APIVersion:"storage.dell.com/v1", ResourceVersion:"892885", FieldPath:""}): type: 'Warning' reason: 'Updated' Failed Prechecks: failed replication validation: TARGET_CLUSTERS_IDS on CR should have more than 0 commma seperated cluster IDs. Got 0

Screenshots

No response

Additional Environment Information

No response

Steps to Reproduce

Attempt to follow the documentation to install CSM-Replication on a single "stretched" cluster.

Expected Behavior

I expect either "self" or "" to be accepted as valid when installing in stretched clsuter mode.

CSM Driver(s)

CSI Driver for PowerScale v2.6.0

Installation Type

CSM-Operater 1.1.0

Container Storage Modules Enabled

No response

Container Orchestrator

Kubernetes v1.25.6

Operating System

RHEL 8.7-2

[csmbot]

@donatwork: Thank you for submitting this issue!

The issue is currently awaiting triage. Please make sure you have given us as much context as possible.

If the maintainers determine this is a relevant issue, they will remove the needs-triage label and assign an appropriate priority label.

---

We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at container.storage.modules@dell.com.

[donatwork]

There is a value, skip-replication-cluster-check which is in the code which gets past the issue int he precheck and all pods end up getting installed. Still need to verify if the install will actually work.

[donatwork]

Another thing. The replication controller is being attempted at install although the Operator install instructions points to the repctl instructions which also installs the replication controller. This may be causing errors int he Operator installation:

Event(v1.ObjectReference{Kind:"ContainerStorageModule", Namespace:"isilon", Name:"isilon", UID:"7cbff48b-c634-4540-ada9-915f5acabfe8", APIVersion:"storage.dell.com/v1", ResourceVersion:"2414290", FieldPath:""}): type: 'Warning' reason: 'Updated' Failed install: failed to deploy replication controller: clusterroles.rbac.authorization.k8s.io "dell-replication-manager-role" is forbidden: user "system:serviceaccount:dell-csm-operator:dell-csm-operator-manager-service-account" (groups=["system:serviceaccounts" "system:serviceaccounts:dell-csm-operator" "system:authenticated"]) is attempting to grant RBAC permissions not currently held:
{APIGroups:[""], Resources:["namespaces"], Verbs:["create"]}

Suggest that Operator not attempt to install the replication controller?

[donatwork]

Updated headline to reflect that there are problems with both the documentation and Operator when installing Replication in the current release.

[donatwork]

Documentation for Operator installation has been updated in dell/csm-docs#612.

[rensyct]

Issues are fixed and are available at main