Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ome_template not idempotent #255

Closed
TrevorSquillario opened this issue Mar 29, 2021 · 4 comments · Fixed by #391
Closed

ome_template not idempotent #255

TrevorSquillario opened this issue Mar 29, 2021 · 4 comments · Fixed by #391
Labels
area/ome ome modules area/ome-modular OME-Modular modules type/feature A feature. This label is applied to a feature issues.
Milestone

Comments

@TrevorSquillario
Copy link
Contributor

When running the module if the template exists it fails breaking the task sequence that follows. This does not follow the Ansible guidelines for module development. Need to check to see if a template by this name exists and if it does return changed = false. This would apply to the 'create' and 'import' actions.

fatal: [MX7000-C38ZZZZ]: FAILED! => {"changed": false, "error_info": {"error": {"@Message.ExtendedInfo": [{"Message": "Unable to create the template because the template name 001Test already exists.", "MessageArgs": ["001Test"], "MessageId": "CTEM1027", "RelatedProperties": [], "Resolution": "Enter a unique template name and retry the operation.", "Severity": "Warning"}], "code": "Base.1.0.GeneralError", "message": "A general error has occurred. See ExtendedInfo for more information."}}, "msg": "HTTP Error 400: Bad Request"}

@ImranJMughal
Copy link

@anupamaloke - Hi Anupam - Do you know when this will be looked at?

Thanks

Imran

@anupamaloke
Copy link
Collaborator

@ImranJMughal, it is in the list of our To-Do items. We will be prioritizing it for next couple of minor releases.

@MallocArray
Copy link

+1 to this as it also applies to the modify command, always showing it changed something, even if the template had the modifications already in place

@anupamaloke anupamaloke added this to the v5.1.0 milestone Feb 1, 2022
@anupamaloke anupamaloke modified the milestones: v5.1.0, v5.2.0 Feb 28, 2022
@anupamaloke anupamaloke added area/ome ome modules area/ome-modular OME-Modular modules type/feature A feature. This label is applied to a feature issues. and removed idempotency labels Mar 9, 2022
@sachin-apa
Copy link
Collaborator

Merged as part of the PR #391 Release 5.2.0

@sachin-apa sachin-apa linked a pull request Mar 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ome ome modules area/ome-modular OME-Modular modules type/feature A feature. This label is applied to a feature issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants