ome_diagnostics does not respect check_mode

[MallocArray]

Summary

When using the ome_diagnostics module and running the playbook in check mode, the full task is ran, logs are extracted, when the expectation is that in check_mode it would not actually run the task the results in files being created. Same happens with log_type: application or support_assist_collection

Component Name

ome_diagnostics

Ansible Version

ansible 2.10.11
  config file = /home/username/Ansible/ansible.cfg
  configured module search path = ['/home/username/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.8 (default, Aug 12 2021, 07:06:15) [GCC 8.4.1 20200928 (Red Hat 8.4.1-1)]

iDRAC or OpenManage Enterprise version

OME-M version 1.30.00

Steps to Reproduce

Run a playbook that extracts logs from an MX7000 chassis group to a CIFS location with check mode enabled at the command prompt.

Playbook used

  tasks:
    - name: Extract Logs from MX7000 chassis to CIFS share location
      # https://github.com/dell/dellemc-openmanage-ansible-modules/blob/collections/docs/modules/ome_diagnostics.rst
      dellemc.openmanage.ome_diagnostics:
        hostname: "{{ inventory_hostname }}"
        username: "{{ dell_ome_username }}"
        password: "{{ dell_ome_password }}"
        share_type: CIFS
        share_address: "{{ cifs_server_ip }}"
        share_name: "{{ cifs_share }}{{ cifs_path | default(omit) }}"
        share_user: "{{ cifs_username }}"
        share_password: "{{ cifs_password }}"
        log_type: application
        mask_sensitive_info: false
        job_wait: true

Expected Results

The expectation is that it will check if the task would run, but not actually run the log extract or at least not generate the output files in the destination folder. At a minimum it should just skip the task if check_mode is used and the module is unable to check, but there is a parameter to test the connection, so check mode could run only the test connection to ensure the destination path is valid and the parameters are valid but not actually run the extract log task.

Actual Results

Instead, the entire task runs in full, creating files and taking 8-15 minutes.

Community Note

• Please vote on this issue by adding a 👍 reaction
  to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions,
  they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment