Skip to content

Commit 0edd9f5

Browse files
Yang Erkunmehmetb0
authored andcommitted
nfsd: make sure exp active before svc_export_show
BugLink: https://bugs.launchpad.net/bugs/2095283 commit be8f982 upstream. The function `e_show` was called with protection from RCU. This only ensures that `exp` will not be freed. Therefore, the reference count for `exp` can drop to zero, which will trigger a refcount use-after-free warning when `exp_get` is called. To resolve this issue, use `cache_get_rcu` to ensure that `exp` remains active. ------------[ cut here ]------------ refcount_t: addition on 0; use-after-free. WARNING: CPU: 3 PID: 819 at lib/refcount.c:25 refcount_warn_saturate+0xb1/0x120 CPU: 3 UID: 0 PID: 819 Comm: cat Not tainted 6.12.0-rc3+ #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.1-2.fc37 04/01/2014 RIP: 0010:refcount_warn_saturate+0xb1/0x120 ... Call Trace: <TASK> e_show+0x20b/0x230 [nfsd] seq_read_iter+0x589/0x770 seq_read+0x1e5/0x270 vfs_read+0x125/0x530 ksys_read+0xc1/0x160 do_syscall_64+0x5f/0x170 entry_SYSCALL_64_after_hwframe+0x76/0x7e Fixes: bf18f16 ("NFSD: Using exp_get for export getting") Cc: stable@vger.kernel.org # 4.20+ Signed-off-by: Yang Erkun <yangerkun@huawei.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> CVE-2024-56558 Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
1 parent bc1969a commit 0edd9f5

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

fs/nfsd/export.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1324,9 +1324,12 @@ static int e_show(struct seq_file *m, void *p)
13241324
return 0;
13251325
}
13261326

1327-
exp_get(exp);
1327+
if (!cache_get_rcu(&exp->h))
1328+
return 0;
1329+
13281330
if (cache_check(cd, &exp->h, NULL))
13291331
return 0;
1332+
13301333
exp_put(exp);
13311334
return svc_export_show(m, cd, cp);
13321335
}

0 commit comments

Comments
 (0)