Skip to content

Commit 6c160b6

Browse files
geliangtangdavem330
authored andcommitted
selftests: mptcp: update userspace pm subflow tests
To align with what is done by the in-kernel PM, update userspace pm subflow selftests, by sending the a remove_addrs command together before the remove_subflows command. This will get a RM_ADDR in chk_rm_nr(). Fixes: d9a4594 ("mptcp: netlink: Add MPTCP_PM_CMD_REMOVE") Fixes: 5e986ec ("selftests: mptcp: userspace pm subflow tests") Link: multipath-tcp/mptcp_net-next#379 Cc: stable@vger.kernel.org Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net> Signed-off-by: Geliang Tang <geliang.tang@suse.com> Signed-off-by: Mat Martineau <martineau@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 24430f8 commit 6c160b6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

tools/testing/selftests/net/mptcp/mptcp_join.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -936,6 +936,7 @@ do_transfer()
936936
sleep 1
937937
sp=$(grep "type:10" "$evts_ns2" |
938938
sed -n 's/.*\(sport:\)\([[:digit:]]*\).*$/\2/p;q')
939+
ip netns exec ${connector_ns} ./pm_nl_ctl rem token $tk id $id
939940
ip netns exec ${connector_ns} ./pm_nl_ctl dsf lip $addr lport $sp \
940941
rip $da rport $dp token $tk
941942
fi
@@ -3150,7 +3151,7 @@ userspace_tests()
31503151
pm_nl_set_limits $ns1 0 1
31513152
run_tests $ns1 $ns2 10.0.1.1 0 0 userspace_1 slow
31523153
chk_join_nr 1 1 1
3153-
chk_rm_nr 0 1
3154+
chk_rm_nr 1 1
31543155
kill_events_pids
31553156
fi
31563157
}

0 commit comments

Comments
 (0)