Skip to content

Commit 6f1ff76

Browse files
AxelLinbroonie
authored andcommitted
regulator: bd70528: Remove .set_ramp_delay for bd70528_ldo_ops
The .set_ramp_delay should be for bd70528_buck_ops only. Setting .set_ramp_delay for for bd70528_ldo_ops causes problem because BD70528_MASK_BUCK_RAMP (0x10) overlaps with BD70528_MASK_LDO_VOLT (0x1f). So setting ramp_delay for LDOs may change the voltage output, fix it. Fixes: 99ea37b ("regulator: bd70528: Support ROHM BD70528 regulator block") Signed-off-by: Axel Lin <axel.lin@ingics.com> Acked-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> Link: https://lore.kernel.org/r/20200101022406.15176-1-axel.lin@ingics.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 71dd2fe commit 6f1ff76

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/regulator/bd70528-regulator.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ static const struct regulator_ops bd70528_ldo_ops = {
101101
.set_voltage_sel = regulator_set_voltage_sel_regmap,
102102
.get_voltage_sel = regulator_get_voltage_sel_regmap,
103103
.set_voltage_time_sel = regulator_set_voltage_time_sel,
104-
.set_ramp_delay = bd70528_set_ramp_delay,
105104
};
106105

107106
static const struct regulator_ops bd70528_led_ops = {

0 commit comments

Comments
 (0)