usb: typec: tipd: Fix wakeup source leaks on device unbind

krzk · smb49 · commit cdaebfde1d94 · 2025-09-16T14:52:01.000+02:00
BugLink: https://bugs.launchpad.net/bugs/2121266 [ Upstream commit aaa8f2e959341fd4a3ccf111500eb1e6176678e0 ] Device can be unbound, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://lore.kernel.org/r/20250406204051.63446-2-krzysztof.kozlowski@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Noah Wager <noah.wager@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
@@ -1431,7 +1431,7 @@ static int tps6598x_probe(struct i2c_client *client)
 
 	tps->wakeup = device_property_read_bool(tps->dev, "wakeup-source");
 	if (tps->wakeup && client->irq) {
-		device_init_wakeup(&client->dev, true);
+		devm_device_init_wakeup(&client->dev);
 		enable_irq_wake(client->irq);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1431,7 +1431,7 @@ static int tps6598x_probe(struct i2c_client *client)`
`1431`	`1431`
`1432`	`1432`	`tps->wakeup = device_property_read_bool(tps->dev, "wakeup-source");`
`1433`	`1433`	`if (tps->wakeup && client->irq) {`
`1434`		`- device_init_wakeup(&client->dev, true);`
	`1434`	`+ devm_device_init_wakeup(&client->dev);`
`1435`	`1435`	`enable_irq_wake(client->irq);`
`1436`	`1436`	`}`
`1437`	`1437`