Skip to content

Commit f116e55

Browse files
zandarksacilotto
authored andcommitted
ARM: dts: imx6dl-yapp4: Fix lp5562 LED driver probe
BugLink: https://bugs.launchpad.net/bugs/1951643 commit 9b663b3 upstream. Since the LED multicolor framework support was added in commit 92a8156 ("leds: lp55xx: Add multicolor framework support to lp55xx") LEDs on this platform stopped working. Author of the framework attempted to accommodate this DT to the framework in commit b86d3d2 ("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node") but that is not sufficient. A color property is now required even if the multicolor framework is not used, otherwise the driver probe fails: lp5562: probe of 1-0030 failed with error -22 Add the color property to fix this. Fixes: 92a8156 ("leds: lp55xx: Add multicolor framework support to lp55xx") Cc: <stable@vger.kernel.org> Cc: linux-leds@vger.kernel.org Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> Acked-by: Pavel Machek <pavel@ucw.cz> Reviewed-by: Fabio Estevam <festevam@gmail.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
1 parent 3bd80b6 commit f116e55

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

arch/arm/boot/dts/imx6dl-yapp4-common.dtsi

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
#include <dt-bindings/gpio/gpio.h>
66
#include <dt-bindings/interrupt-controller/irq.h>
77
#include <dt-bindings/input/input.h>
8+
#include <dt-bindings/leds/common.h>
89
#include <dt-bindings/pwm/pwm.h>
910

1011
/ {
@@ -275,27 +276,31 @@
275276
led-cur = /bits/ 8 <0x20>;
276277
max-cur = /bits/ 8 <0x60>;
277278
reg = <0>;
279+
color = <LED_COLOR_ID_RED>;
278280
};
279281

280282
chan@1 {
281283
chan-name = "G";
282284
led-cur = /bits/ 8 <0x20>;
283285
max-cur = /bits/ 8 <0x60>;
284286
reg = <1>;
287+
color = <LED_COLOR_ID_GREEN>;
285288
};
286289

287290
chan@2 {
288291
chan-name = "B";
289292
led-cur = /bits/ 8 <0x20>;
290293
max-cur = /bits/ 8 <0x60>;
291294
reg = <2>;
295+
color = <LED_COLOR_ID_BLUE>;
292296
};
293297

294298
chan@3 {
295299
chan-name = "W";
296300
led-cur = /bits/ 8 <0x0>;
297301
max-cur = /bits/ 8 <0x0>;
298302
reg = <3>;
303+
color = <LED_COLOR_ID_WHITE>;
299304
};
300305
};
301306

0 commit comments

Comments
 (0)