xen-blkfront: use true and false for boolean values

GustavoARSilva · axboe · commit f87c30c96cd9 · 2018-08-06T08:14:55.000-06:00
Return statements in functions returning bool should use true or false
instead of an integer value.

This code was detected with the help of Coccinelle.

Acked-by: Roger Pau Monné &lt;roger.pau@citrix.com&gt;
Signed-off-by: Gustavo A. R. Silva &lt;gustavo@embeddedor.com&gt;
Signed-off-by: Jens Axboe &lt;axboe@kernel.dk&gt;
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
@@ -1436,7 +1436,7 @@ static bool blkif_completion(unsigned long *id,
 
 		/* Wait the second response if not yet here. */
 		if (s2->status == REQ_WAITING)
-			return 0;
+			return false;
 
 		bret->status = blkif_get_final_status(s->status,
 						      s2->status);
@@ -1537,7 +1537,7 @@ static bool blkif_completion(unsigned long *id,
 		}
 	}
 
-	return 1;
+	return true;
 }
 
 static irqreturn_t blkif_interrupt(int irq, void *dev_id)

Original file line number	Diff line number	Diff line change
`@@ -1436,7 +1436,7 @@ static bool blkif_completion(unsigned long *id,`
`1436`	`1436`
`1437`	`1437`	`/* Wait the second response if not yet here. */`
`1438`	`1438`	`if (s2->status == REQ_WAITING)`
`1439`		`- return 0;`
	`1439`	`+ return false;`
`1440`	`1440`
`1441`	`1441`	`bret->status = blkif_get_final_status(s->status,`
`1442`	`1442`	`s2->status);`
`@@ -1537,7 +1537,7 @@ static bool blkif_completion(unsigned long *id,`
`1537`	`1537`	`}`
`1538`	`1538`	`}`
`1539`	`1539`
`1540`		`- return 1;`
	`1540`	`+ return true;`
`1541`	`1541`	`}`
`1542`	`1542`
`1543`	`1543`	`static irqreturn_t blkif_interrupt(int irq, void *dev_id)`