Skip to content

Commit 1c44711

Browse files
ahunter6storulf
authored andcommitted
mmc: mmc: Fix partition switch timeout for some eMMCs
Some eMMCs set the partition switch timeout too low. Now typically eMMCs are considered a critical component (e.g. because they store the root file system) and consequently are expected to be reliable. Thus we can neglect the use case where eMMCs can't switch reliably and we might want a lower timeout to facilitate speedy recovery. Although we could employ a quirk for the cards that are affected (if we could identify them all), as described above, there is little benefit to having a low timeout, so instead simply set a minimum timeout. The minimum is set to 300ms somewhat arbitrarily - the examples that have been seen had a timeout of 10ms but were sometimes taking 60-70ms. Cc: stable@vger.kernel.org Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent 685d29e commit 1c44711

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

drivers/mmc/core/mmc.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,9 @@ static void mmc_manage_gp_partitions(struct mmc_card *card, u8 *ext_csd)
333333
}
334334
}
335335

336+
/* Minimum partition switch timeout in milliseconds */
337+
#define MMC_MIN_PART_SWITCH_TIME 300
338+
336339
/*
337340
* Decode extended CSD.
338341
*/
@@ -397,6 +400,10 @@ static int mmc_decode_ext_csd(struct mmc_card *card, u8 *ext_csd)
397400

398401
/* EXT_CSD value is in units of 10ms, but we store in ms */
399402
card->ext_csd.part_time = 10 * ext_csd[EXT_CSD_PART_SWITCH_TIME];
403+
/* Some eMMC set the value too low so set a minimum */
404+
if (card->ext_csd.part_time &&
405+
card->ext_csd.part_time < MMC_MIN_PART_SWITCH_TIME)
406+
card->ext_csd.part_time = MMC_MIN_PART_SWITCH_TIME;
400407

401408
/* Sleep / awake timeout in 100ns units */
402409
if (sa_shift > 0 && sa_shift <= 0x17)

0 commit comments

Comments
 (0)