spi: stm32: Fix error handling in stm32_spi_probe()

khoroshilov · broonie · commit 3dbb3eef91fd · 2018-04-17T11:46:23.000+01:00
clk_get_rate() is below clk_prepare_enable(), so
its error should lead to goto err_clk_disable, not to err_master_put.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov &lt;khoroshilov@ispras.ru&gt;
Reviewed-by: Amelie Delaunay &lt;amelie.delaunay@st.com&gt;
Signed-off-by: Mark Brown &lt;broonie@kernel.org&gt;
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
@@ -1129,7 +1129,7 @@ static int stm32_spi_probe(struct platform_device *pdev)
 	if (!spi->clk_rate) {
 		dev_err(&pdev->dev, "clk rate = 0\n");
 		ret = -EINVAL;
-		goto err_master_put;
+		goto err_clk_disable;
 	}
 
 	spi->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);

Original file line number	Diff line number	Diff line change
`@@ -1129,7 +1129,7 @@ static int stm32_spi_probe(struct platform_device *pdev)`
`1129`	`1129`	`if (!spi->clk_rate) {`
`1130`	`1130`	`dev_err(&pdev->dev, "clk rate = 0\n");`
`1131`	`1131`	`ret = -EINVAL;`
`1132`		`- goto err_master_put;`
	`1132`	`+ goto err_clk_disable;`
`1133`	`1133`	`}`
`1134`	`1134`
`1135`	`1135`	`spi->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);`