Skip to content

Commit 03f5bd7

Browse files
DaveWysochanskiRHamschuma-ntap
authored andcommitted
NFS: Remove fscache specific trace points and NFS_INO_FSCACHE bit
The NFS specific trace points are no longer needed as tracing is well covered by netfs and fscache. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Tested-by: Daire Byrne <daire@dneg.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
1 parent 0631d5e commit 03f5bd7

File tree

2 files changed

+0
-92
lines changed

2 files changed

+0
-92
lines changed

fs/nfs/nfstrace.h

Lines changed: 0 additions & 91 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
{ BIT(NFS_INO_STALE), "STALE" }, \
4040
{ BIT(NFS_INO_ACL_LRU_SET), "ACL_LRU_SET" }, \
4141
{ BIT(NFS_INO_INVALIDATING), "INVALIDATING" }, \
42-
{ BIT(NFS_INO_FSCACHE), "FSCACHE" }, \
4342
{ BIT(NFS_INO_LAYOUTCOMMIT), "NEED_LAYOUTCOMMIT" }, \
4443
{ BIT(NFS_INO_LAYOUTCOMMITTING), "LAYOUTCOMMIT" }, \
4544
{ BIT(NFS_INO_LAYOUTSTATS), "LAYOUTSTATS" }, \
@@ -1243,96 +1242,6 @@ TRACE_EVENT(nfs_readpage_short,
12431242
)
12441243
);
12451244

1246-
DECLARE_EVENT_CLASS(nfs_fscache_page_event,
1247-
TP_PROTO(
1248-
const struct inode *inode,
1249-
struct page *page
1250-
),
1251-
1252-
TP_ARGS(inode, page),
1253-
1254-
TP_STRUCT__entry(
1255-
__field(dev_t, dev)
1256-
__field(u32, fhandle)
1257-
__field(u64, fileid)
1258-
__field(loff_t, offset)
1259-
),
1260-
1261-
TP_fast_assign(
1262-
const struct nfs_inode *nfsi = NFS_I(inode);
1263-
const struct nfs_fh *fh = &nfsi->fh;
1264-
1265-
__entry->offset = page_index(page) << PAGE_SHIFT;
1266-
__entry->dev = inode->i_sb->s_dev;
1267-
__entry->fileid = nfsi->fileid;
1268-
__entry->fhandle = nfs_fhandle_hash(fh);
1269-
),
1270-
1271-
TP_printk(
1272-
"fileid=%02x:%02x:%llu fhandle=0x%08x "
1273-
"offset=%lld",
1274-
MAJOR(__entry->dev), MINOR(__entry->dev),
1275-
(unsigned long long)__entry->fileid,
1276-
__entry->fhandle,
1277-
(long long)__entry->offset
1278-
)
1279-
);
1280-
DECLARE_EVENT_CLASS(nfs_fscache_page_event_done,
1281-
TP_PROTO(
1282-
const struct inode *inode,
1283-
struct page *page,
1284-
int error
1285-
),
1286-
1287-
TP_ARGS(inode, page, error),
1288-
1289-
TP_STRUCT__entry(
1290-
__field(int, error)
1291-
__field(dev_t, dev)
1292-
__field(u32, fhandle)
1293-
__field(u64, fileid)
1294-
__field(loff_t, offset)
1295-
),
1296-
1297-
TP_fast_assign(
1298-
const struct nfs_inode *nfsi = NFS_I(inode);
1299-
const struct nfs_fh *fh = &nfsi->fh;
1300-
1301-
__entry->offset = page_index(page) << PAGE_SHIFT;
1302-
__entry->dev = inode->i_sb->s_dev;
1303-
__entry->fileid = nfsi->fileid;
1304-
__entry->fhandle = nfs_fhandle_hash(fh);
1305-
__entry->error = error;
1306-
),
1307-
1308-
TP_printk(
1309-
"fileid=%02x:%02x:%llu fhandle=0x%08x "
1310-
"offset=%lld error=%d",
1311-
MAJOR(__entry->dev), MINOR(__entry->dev),
1312-
(unsigned long long)__entry->fileid,
1313-
__entry->fhandle,
1314-
(long long)__entry->offset, __entry->error
1315-
)
1316-
);
1317-
#define DEFINE_NFS_FSCACHE_PAGE_EVENT(name) \
1318-
DEFINE_EVENT(nfs_fscache_page_event, name, \
1319-
TP_PROTO( \
1320-
const struct inode *inode, \
1321-
struct page *page \
1322-
), \
1323-
TP_ARGS(inode, page))
1324-
#define DEFINE_NFS_FSCACHE_PAGE_EVENT_DONE(name) \
1325-
DEFINE_EVENT(nfs_fscache_page_event_done, name, \
1326-
TP_PROTO( \
1327-
const struct inode *inode, \
1328-
struct page *page, \
1329-
int error \
1330-
), \
1331-
TP_ARGS(inode, page, error))
1332-
DEFINE_NFS_FSCACHE_PAGE_EVENT(nfs_fscache_read_page);
1333-
DEFINE_NFS_FSCACHE_PAGE_EVENT_DONE(nfs_fscache_read_page_exit);
1334-
DEFINE_NFS_FSCACHE_PAGE_EVENT(nfs_fscache_write_page);
1335-
DEFINE_NFS_FSCACHE_PAGE_EVENT_DONE(nfs_fscache_write_page_exit);
13361245

13371246
TRACE_EVENT(nfs_pgio_error,
13381247
TP_PROTO(

include/linux/nfs_fs.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,6 @@ struct nfs4_copy_state {
281281
#define NFS_INO_ACL_LRU_SET (2) /* Inode is on the LRU list */
282282
#define NFS_INO_INVALIDATING (3) /* inode is being invalidated */
283283
#define NFS_INO_PRESERVE_UNLINKED (4) /* preserve file if removed while open */
284-
#define NFS_INO_FSCACHE (5) /* inode can be cached by FS-Cache */
285284
#define NFS_INO_LAYOUTCOMMIT (9) /* layoutcommit required */
286285
#define NFS_INO_LAYOUTCOMMITTING (10) /* layoutcommit inflight */
287286
#define NFS_INO_LAYOUTSTATS (11) /* layoutstats inflight */

0 commit comments

Comments
 (0)