net: axienet: add missing error return code in axienet_probe()

Yang Yingliang · kuba-moo · commit 2e7bf4a6af48 · 2022-06-16T11:08:38.000-07:00
It should return error code in error path in axienet_probe(). Fixes: 00be43a ("net: axienet: make the 64b addresable DMA depends on 64b archectures") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20220616062917.3601-1-yangyingliang@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -2039,6 +2039,7 @@ static int axienet_probe(struct platform_device *pdev)
 	}
 	if (!IS_ENABLED(CONFIG_64BIT) && lp->features & XAE_FEATURE_DMA_64BIT) {
 		dev_err(&pdev->dev, "64-bit addressable DMA is not compatible with 32-bit archecture\n");
+		ret = -EINVAL;
 		goto cleanup_clk;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -2039,6 +2039,7 @@ static int axienet_probe(struct platform_device *pdev)`
`2039`	`2039`	`}`
`2040`	`2040`	`if (!IS_ENABLED(CONFIG_64BIT) && lp->features & XAE_FEATURE_DMA_64BIT) {`
`2041`	`2041`	`dev_err(&pdev->dev, "64-bit addressable DMA is not compatible with 32-bit archecture\n");`
	`2042`	`+ ret = -EINVAL;`
`2042`	`2043`	`goto cleanup_clk;`
`2043`	`2044`	`}`
`2044`	`2045`