Revert "DLPX-84985 target: iscsi: fix deadlock in the iSCSI login code (#22)"

Upstream fixed this bug via https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/noble/commit/?id=13247018d68f21e7132924b9853f7e2c423588b6

Author: palash-gandhi

drivers/target/iscsi/iscsi_target_nego.c

@@ -472,18 +472,12 @@ static int iscsi_target_do_login(struct iscsit_conn *, struct iscsi_login *);
 
 static bool __iscsi_target_sk_check_close(struct sock *sk)
 {
-	switch (sk->sk_state) {
-	case TCP_FIN_WAIT1:
-	case TCP_FIN_WAIT2:
-	case TCP_CLOSE_WAIT:
-	case TCP_LAST_ACK:
-	case TCP_CLOSE:
-		pr_debug("__iscsi_target_sk_check_close: socket closing,"
+	if (sk->sk_state == TCP_CLOSE_WAIT || sk->sk_state == TCP_CLOSE) {
+		pr_debug("__iscsi_target_sk_check_close: TCP_CLOSE_WAIT|TCP_CLOSE,"
 			"returning TRUE\n");
 		return true;
-	default:
-		return false;
 	}
+	return false;
 }
 
 static bool iscsi_target_sk_check_close(struct iscsit_conn *conn)
@@ -645,7 +639,6 @@ static void iscsi_target_do_login_rx(struct work_struct *work)
 	} else if (rc == 1) {
 		iscsit_stop_login_timer(conn);
 		cancel_delayed_work(&conn->login_work);
-		iscsit_stop_login_timer(conn);
 		iscsi_target_nego_release(conn);
 		iscsi_post_login_handler(np, conn, zero_tsih);
 		iscsit_deaccess_np(np, tpg, tpg_np);
@@ -656,7 +649,6 @@ static void iscsi_target_do_login_rx(struct work_struct *work)
 	iscsi_target_restore_sock_callbacks(conn);
 	iscsit_stop_login_timer(conn);
 	cancel_delayed_work(&conn->login_work);
-	iscsit_stop_login_timer(conn);
 	iscsi_target_login_drop(conn, login);
 	iscsit_deaccess_np(np, tpg, tpg_np);
 }
@@ -1360,9 +1352,6 @@ int iscsi_target_start_negotiation(
 		set_bit(LOGIN_FLAGS_INITIAL_PDU, &conn->login_flags);
 		write_unlock_bh(&sk->sk_callback_lock);
 	}
-
-	iscsit_start_login_timer(conn);
-
 	/*
 	 * If iscsi_target_do_login returns zero to signal more PDU
 	 * exchanges are required to complete the login, go ahead and