Skip to content

Commit 888b3c8

Browse files
Pratyush Anandctmarinas
authored andcommitted
arm64: Treat all entry code as non-kprobe-able
Entry symbols are not kprobe safe. So blacklist them for kprobing. Signed-off-by: Pratyush Anand <panand@redhat.com> Signed-off-by: David A. Long <dave.long@linaro.org> Acked-by: Masami Hiramatsu <mhiramat@kernel.org> [catalin.marinas@arm.com: Do not include syscall wrappers in .entry.text] Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
1 parent 44b53f6 commit 888b3c8

File tree

3 files changed

+30
-0
lines changed

3 files changed

+30
-0
lines changed

arch/arm64/kernel/entry.S

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ tsk .req x28 // current thread_info
242242
/*
243243
* Exception vectors.
244244
*/
245+
.pushsection ".entry.text", "ax"
245246

246247
.align 11
247248
ENTRY(vectors)
@@ -774,6 +775,8 @@ __ni_sys_trace:
774775
bl do_ni_syscall
775776
b __sys_trace_return
776777

778+
.popsection // .entry.text
779+
777780
/*
778781
* Special system call wrappers.
779782
*/

arch/arm64/kernel/probes/kprobes.c

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
#include <asm/insn.h>
3131
#include <asm/uaccess.h>
3232
#include <asm/irq.h>
33+
#include <asm-generic/sections.h>
3334

3435
#include "decode-insn.h"
3536

@@ -519,6 +520,31 @@ int __kprobes longjmp_break_handler(struct kprobe *p, struct pt_regs *regs)
519520
return 1;
520521
}
521522

523+
bool arch_within_kprobe_blacklist(unsigned long addr)
524+
{
525+
extern char __idmap_text_start[], __idmap_text_end[];
526+
extern char __hyp_idmap_text_start[], __hyp_idmap_text_end[];
527+
528+
if ((addr >= (unsigned long)__kprobes_text_start &&
529+
addr < (unsigned long)__kprobes_text_end) ||
530+
(addr >= (unsigned long)__entry_text_start &&
531+
addr < (unsigned long)__entry_text_end) ||
532+
(addr >= (unsigned long)__idmap_text_start &&
533+
addr < (unsigned long)__idmap_text_end) ||
534+
!!search_exception_tables(addr))
535+
return true;
536+
537+
if (!is_kernel_in_hyp_mode()) {
538+
if ((addr >= (unsigned long)__hyp_text_start &&
539+
addr < (unsigned long)__hyp_text_end) ||
540+
(addr >= (unsigned long)__hyp_idmap_text_start &&
541+
addr < (unsigned long)__hyp_idmap_text_end))
542+
return true;
543+
}
544+
545+
return false;
546+
}
547+
522548
int __init arch_init_kprobes(void)
523549
{
524550
return 0;

arch/arm64/kernel/vmlinux.lds.S

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ SECTIONS
118118
__exception_text_end = .;
119119
IRQENTRY_TEXT
120120
SOFTIRQENTRY_TEXT
121+
ENTRY_TEXT
121122
TEXT_TEXT
122123
SCHED_TEXT
123124
LOCK_TEXT

0 commit comments

Comments
 (0)