Skip to content

Commit 209c805

Browse files
alcoopervinodkoul
authored andcommitted
phy: usb: Fix incorrect clearing of tca_drv_sel bit in SETUP reg for 7211
The 7211a0 has a tca_drv_sel bit in the USB SETUP register that should never be enabled. This feature is only used if there is a USB Type-C PHY, and the 7211 does not have one. If the bit is enabled, the VBUS signal will never be asserted. In the 7211a0, the bit was incorrectly defaulted to on so the driver had to clear the bit. In the 7211c0 the state was inverted so the driver should no longer clear the bit. This hasn't been a problem because all current 7211 boards don't use the VBUS signal, but there are some future customer boards that may use it. Signed-off-by: Al Cooper <alcooperx@gmail.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com> Link: https://lore.kernel.org/r/20201002190115.48017-1-alcooperx@gmail.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 3650b22 commit 209c805

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/phy/broadcom/phy-brcm-usb-init-synopsys.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -270,11 +270,6 @@ static void usb_init_common_7211b0(struct brcm_usb_init_params *params)
270270
reg |= params->mode << USB_PHY_UTMI_CTL_1_PHY_MODE_SHIFT;
271271
brcm_usb_writel(reg, usb_phy + USB_PHY_UTMI_CTL_1);
272272

273-
/* Fix the incorrect default */
274-
reg = brcm_usb_readl(ctrl + USB_CTRL_SETUP);
275-
reg &= ~USB_CTRL_SETUP_tca_drv_sel_MASK;
276-
brcm_usb_writel(reg, ctrl + USB_CTRL_SETUP);
277-
278273
usb_init_common(params);
279274

280275
/*

0 commit comments

Comments
 (0)