Skip to content

Commit 2b7950c

Browse files
Sergey Shtylyovsre
authored andcommitted
power: supply: mp2629_charger: use platform_get_irq()
Calling platform_get_irq_optional() doesn't make sense if you then bail out on any error it returns. Switch to calling platform_get_irq() instead and remove dev_err() call as platform_get_irq() already curses loudly on error. Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
1 parent 441d38c commit 2b7950c

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/power/supply/mp2629_charger.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -580,11 +580,9 @@ static int mp2629_charger_probe(struct platform_device *pdev)
580580
charger->dev = dev;
581581
platform_set_drvdata(pdev, charger);
582582

583-
irq = platform_get_irq_optional(to_platform_device(dev->parent), 0);
584-
if (irq < 0) {
585-
dev_err(dev, "get irq fail: %d\n", irq);
583+
irq = platform_get_irq(to_platform_device(dev->parent), 0);
584+
if (irq < 0)
586585
return irq;
587-
}
588586

589587
for (i = 0; i < MP2629_MAX_FIELD; i++) {
590588
charger->regmap_fields[i] = devm_regmap_field_alloc(dev,

0 commit comments

Comments
 (0)