Skip to content

Commit 4eaca96

Browse files
VMoolaakpm00
authored andcommitted
powerpc: convert various functions to use ptdescs
In order to split struct ptdesc from struct page, convert various functions to use ptdescs. Link: https://lkml.kernel.org/r/20230807230513.102486-13-vishal.moola@gmail.com Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com> Acked-by: Mike Rapoport (IBM) <rppt@kernel.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Christophe Leroy <christophe.leroy@csgroup.eu> Cc: Claudio Imbrenda <imbrenda@linux.ibm.com> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: David Hildenbrand <david@redhat.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Dinh Nguyen <dinguyen@kernel.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Guo Ren <guoren@kernel.org> Cc: Huacai Chen <chenhuacai@kernel.org> Cc: Hugh Dickins <hughd@google.com> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: Jonas Bonn <jonas@southpole.se> Cc: Matthew Wilcox <willy@infradead.org> Cc: Palmer Dabbelt <palmer@rivosinc.com> Cc: Paul Walmsley <paul.walmsley@sifive.com> Cc: Richard Weinberger <richard@nod.at> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Yoshinori Sato <ysato@users.sourceforge.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7e11dca commit 4eaca96

File tree

3 files changed

+50
-50
lines changed

3 files changed

+50
-50
lines changed

arch/powerpc/mm/book3s64/mmu_context.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -246,15 +246,15 @@ static void destroy_contexts(mm_context_t *ctx)
246246
static void pmd_frag_destroy(void *pmd_frag)
247247
{
248248
int count;
249-
struct page *page;
249+
struct ptdesc *ptdesc;
250250

251-
page = virt_to_page(pmd_frag);
251+
ptdesc = virt_to_ptdesc(pmd_frag);
252252
/* drop all the pending references */
253253
count = ((unsigned long)pmd_frag & ~PAGE_MASK) >> PMD_FRAG_SIZE_SHIFT;
254254
/* We allow PTE_FRAG_NR fragments from a PTE page */
255-
if (atomic_sub_and_test(PMD_FRAG_NR - count, &page->pt_frag_refcount)) {
256-
pgtable_pmd_page_dtor(page);
257-
__free_page(page);
255+
if (atomic_sub_and_test(PMD_FRAG_NR - count, &ptdesc->pt_frag_refcount)) {
256+
pagetable_pmd_dtor(ptdesc);
257+
pagetable_free(ptdesc);
258258
}
259259
}
260260

arch/powerpc/mm/book3s64/pgtable.c

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -384,22 +384,22 @@ static pmd_t *get_pmd_from_cache(struct mm_struct *mm)
384384
static pmd_t *__alloc_for_pmdcache(struct mm_struct *mm)
385385
{
386386
void *ret = NULL;
387-
struct page *page;
387+
struct ptdesc *ptdesc;
388388
gfp_t gfp = GFP_KERNEL_ACCOUNT | __GFP_ZERO;
389389

390390
if (mm == &init_mm)
391391
gfp &= ~__GFP_ACCOUNT;
392-
page = alloc_page(gfp);
393-
if (!page)
392+
ptdesc = pagetable_alloc(gfp, 0);
393+
if (!ptdesc)
394394
return NULL;
395-
if (!pgtable_pmd_page_ctor(page)) {
396-
__free_pages(page, 0);
395+
if (!pagetable_pmd_ctor(ptdesc)) {
396+
pagetable_free(ptdesc);
397397
return NULL;
398398
}
399399

400-
atomic_set(&page->pt_frag_refcount, 1);
400+
atomic_set(&ptdesc->pt_frag_refcount, 1);
401401

402-
ret = page_address(page);
402+
ret = ptdesc_address(ptdesc);
403403
/*
404404
* if we support only one fragment just return the
405405
* allocated page.
@@ -409,12 +409,12 @@ static pmd_t *__alloc_for_pmdcache(struct mm_struct *mm)
409409

410410
spin_lock(&mm->page_table_lock);
411411
/*
412-
* If we find pgtable_page set, we return
412+
* If we find ptdesc_page set, we return
413413
* the allocated page with single fragment
414414
* count.
415415
*/
416416
if (likely(!mm->context.pmd_frag)) {
417-
atomic_set(&page->pt_frag_refcount, PMD_FRAG_NR);
417+
atomic_set(&ptdesc->pt_frag_refcount, PMD_FRAG_NR);
418418
mm->context.pmd_frag = ret + PMD_FRAG_SIZE;
419419
}
420420
spin_unlock(&mm->page_table_lock);
@@ -435,15 +435,15 @@ pmd_t *pmd_fragment_alloc(struct mm_struct *mm, unsigned long vmaddr)
435435

436436
void pmd_fragment_free(unsigned long *pmd)
437437
{
438-
struct page *page = virt_to_page(pmd);
438+
struct ptdesc *ptdesc = virt_to_ptdesc(pmd);
439439

440-
if (PageReserved(page))
441-
return free_reserved_page(page);
440+
if (pagetable_is_reserved(ptdesc))
441+
return free_reserved_ptdesc(ptdesc);
442442

443-
BUG_ON(atomic_read(&page->pt_frag_refcount) <= 0);
444-
if (atomic_dec_and_test(&page->pt_frag_refcount)) {
445-
pgtable_pmd_page_dtor(page);
446-
__free_page(page);
443+
BUG_ON(atomic_read(&ptdesc->pt_frag_refcount) <= 0);
444+
if (atomic_dec_and_test(&ptdesc->pt_frag_refcount)) {
445+
pagetable_pmd_dtor(ptdesc);
446+
pagetable_free(ptdesc);
447447
}
448448
}
449449

arch/powerpc/mm/pgtable-frag.c

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@
1818
void pte_frag_destroy(void *pte_frag)
1919
{
2020
int count;
21-
struct page *page;
21+
struct ptdesc *ptdesc;
2222

23-
page = virt_to_page(pte_frag);
23+
ptdesc = virt_to_ptdesc(pte_frag);
2424
/* drop all the pending references */
2525
count = ((unsigned long)pte_frag & ~PAGE_MASK) >> PTE_FRAG_SIZE_SHIFT;
2626
/* We allow PTE_FRAG_NR fragments from a PTE page */
27-
if (atomic_sub_and_test(PTE_FRAG_NR - count, &page->pt_frag_refcount)) {
28-
pgtable_pte_page_dtor(page);
29-
__free_page(page);
27+
if (atomic_sub_and_test(PTE_FRAG_NR - count, &ptdesc->pt_frag_refcount)) {
28+
pagetable_pte_dtor(ptdesc);
29+
pagetable_free(ptdesc);
3030
}
3131
}
3232

@@ -55,25 +55,25 @@ static pte_t *get_pte_from_cache(struct mm_struct *mm)
5555
static pte_t *__alloc_for_ptecache(struct mm_struct *mm, int kernel)
5656
{
5757
void *ret = NULL;
58-
struct page *page;
58+
struct ptdesc *ptdesc;
5959

6060
if (!kernel) {
61-
page = alloc_page(PGALLOC_GFP | __GFP_ACCOUNT);
62-
if (!page)
61+
ptdesc = pagetable_alloc(PGALLOC_GFP | __GFP_ACCOUNT, 0);
62+
if (!ptdesc)
6363
return NULL;
64-
if (!pgtable_pte_page_ctor(page)) {
65-
__free_page(page);
64+
if (!pagetable_pte_ctor(ptdesc)) {
65+
pagetable_free(ptdesc);
6666
return NULL;
6767
}
6868
} else {
69-
page = alloc_page(PGALLOC_GFP);
70-
if (!page)
69+
ptdesc = pagetable_alloc(PGALLOC_GFP, 0);
70+
if (!ptdesc)
7171
return NULL;
7272
}
7373

74-
atomic_set(&page->pt_frag_refcount, 1);
74+
atomic_set(&ptdesc->pt_frag_refcount, 1);
7575

76-
ret = page_address(page);
76+
ret = ptdesc_address(ptdesc);
7777
/*
7878
* if we support only one fragment just return the
7979
* allocated page.
@@ -82,12 +82,12 @@ static pte_t *__alloc_for_ptecache(struct mm_struct *mm, int kernel)
8282
return ret;
8383
spin_lock(&mm->page_table_lock);
8484
/*
85-
* If we find pgtable_page set, we return
85+
* If we find ptdesc_page set, we return
8686
* the allocated page with single fragment
8787
* count.
8888
*/
8989
if (likely(!pte_frag_get(&mm->context))) {
90-
atomic_set(&page->pt_frag_refcount, PTE_FRAG_NR);
90+
atomic_set(&ptdesc->pt_frag_refcount, PTE_FRAG_NR);
9191
pte_frag_set(&mm->context, ret + PTE_FRAG_SIZE);
9292
}
9393
spin_unlock(&mm->page_table_lock);
@@ -108,28 +108,28 @@ pte_t *pte_fragment_alloc(struct mm_struct *mm, int kernel)
108108

109109
static void pte_free_now(struct rcu_head *head)
110110
{
111-
struct page *page;
111+
struct ptdesc *ptdesc;
112112

113-
page = container_of(head, struct page, rcu_head);
114-
pgtable_pte_page_dtor(page);
115-
__free_page(page);
113+
ptdesc = container_of(head, struct ptdesc, pt_rcu_head);
114+
pagetable_pte_dtor(ptdesc);
115+
pagetable_free(ptdesc);
116116
}
117117

118118
void pte_fragment_free(unsigned long *table, int kernel)
119119
{
120-
struct page *page = virt_to_page(table);
120+
struct ptdesc *ptdesc = virt_to_ptdesc(table);
121121

122-
if (PageReserved(page))
123-
return free_reserved_page(page);
122+
if (pagetable_is_reserved(ptdesc))
123+
return free_reserved_ptdesc(ptdesc);
124124

125-
BUG_ON(atomic_read(&page->pt_frag_refcount) <= 0);
126-
if (atomic_dec_and_test(&page->pt_frag_refcount)) {
125+
BUG_ON(atomic_read(&ptdesc->pt_frag_refcount) <= 0);
126+
if (atomic_dec_and_test(&ptdesc->pt_frag_refcount)) {
127127
if (kernel)
128-
__free_page(page);
129-
else if (TestClearPageActive(page))
130-
call_rcu(&page->rcu_head, pte_free_now);
128+
pagetable_free(ptdesc);
129+
else if (folio_test_clear_active(ptdesc_folio(ptdesc)))
130+
call_rcu(&ptdesc->pt_rcu_head, pte_free_now);
131131
else
132-
pte_free_now(&page->rcu_head);
132+
pte_free_now(&ptdesc->pt_rcu_head);
133133
}
134134
}
135135

0 commit comments

Comments
 (0)