net: dsa: rzn1-a5psw: add missing of_node_put() in a5psw_pcs_get()

Yang Yingliang · kuba-moo · commit 5a24389457ba · 2022-06-30T21:07:03.000-07:00
of_parse_phandle() will increase the refcount of 'pcs_node', so add of_node_put() before return from a5psw_pcs_get(). Fixes: 888cdb8 ("net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20220630014153.1888811-1-yangyingliang@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c
@@ -917,12 +917,14 @@ static int a5psw_pcs_get(struct a5psw *a5psw)
 		}
 
 		a5psw->pcs[reg] = pcs;
+		of_node_put(pcs_node);
 	}
 	of_node_put(ports);
 
 	return 0;
 
 free_pcs:
+	of_node_put(pcs_node);
 	of_node_put(port);
 	of_node_put(ports);
 	a5psw_pcs_free(a5psw);

Original file line number	Diff line number	Diff line change
`@@ -917,12 +917,14 @@ static int a5psw_pcs_get(struct a5psw *a5psw)`
`917`	`917`	`}`
`918`	`918`
`919`	`919`	`a5psw->pcs[reg] = pcs;`
	`920`	`+ of_node_put(pcs_node);`
`920`	`921`	`}`
`921`	`922`	`of_node_put(ports);`
`922`	`923`
`923`	`924`	`return 0;`
`924`	`925`
`925`	`926`	`free_pcs:`
	`927`	`+ of_node_put(pcs_node);`
`926`	`928`	`of_node_put(port);`
`927`	`929`	`of_node_put(ports);`
`928`	`930`	`a5psw_pcs_free(a5psw);`