Skip to content

Commit 621735f

Browse files
hkallweitkuba-moo
authored andcommitted
r8169: fix rare issue with broken rx after link-down on RTL8125
In very rare cases (I've seen two reports so far about different RTL8125 chip versions) it seems the MAC locks up when link goes down and requires a software reset to get revived. Realtek doesn't publish hw errata information, therefore the root cause is unknown. Realtek vendor drivers do a full hw re-initialization on each link-up event, the slimmed-down variant here was reported to fix the issue for the reporting user. It's not fully clear which parts of the NIC are reset as part of the software reset, therefore I can't rule out side effects. Fixes: f1bce4a ("r8169: add support for RTL8125") Reported-by: Martin Kjær Jørgensen <me@lagy.org> Link: https://lore.kernel.org/netdev/97ec2232-3257-316c-c3e7-a08192ce16a6@gmail.com/T/ Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Link: https://lore.kernel.org/r/9edde757-9c3b-4730-be3b-0ef3a374ff71@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 1efddc0 commit 621735f

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/net/ethernet/realtek/r8169_main.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4596,7 +4596,11 @@ static void r8169_phylink_handler(struct net_device *ndev)
45964596
if (netif_carrier_ok(ndev)) {
45974597
rtl_link_chg_patch(tp);
45984598
pm_request_resume(d);
4599+
netif_wake_queue(tp->dev);
45994600
} else {
4601+
/* In few cases rx is broken after link-down otherwise */
4602+
if (rtl_is_8125(tp))
4603+
rtl_reset_work(tp);
46004604
pm_runtime_idle(d);
46014605
}
46024606

0 commit comments

Comments
 (0)