Skip to content

Commit 85372c6

Browse files
Alexander Gordeevacmel
authored andcommitted
perf bench numa: Fix benchmark names
Standard benchmark names let users know the tests specifics. For example "2x1-bw-process" name tells that two processes one thread each are run and the RAM bandwidth is measured. Several benchmarks names do not correspond to their actual running configuration. Fix that and also some whitespace and comment inconsistencies. Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lore.kernel.org/lkml/6b6f2084f132ee8e9203dc7c32f9deb209b87a68.1597004831.git.agordeev@linux.ibm.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 72d69c2 commit 85372c6

File tree

1 file changed

+17
-18
lines changed

1 file changed

+17
-18
lines changed

tools/perf/bench/numa.c

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -813,12 +813,12 @@ static u64 do_work(u8 *__data, long bytes, int nr, int nr_max, int loop, u64 val
813813
}
814814
}
815815
} else if (!g->p.data_backwards || (nr + loop) & 1) {
816+
/* Process data forwards: */
816817

817818
d0 = data + off;
818819
d = data + off + 1;
819820
d1 = data + words;
820821

821-
/* Process data forwards: */
822822
for (;;) {
823823
if (unlikely(d >= d1))
824824
d = data;
@@ -836,7 +836,6 @@ static u64 do_work(u8 *__data, long bytes, int nr, int nr_max, int loop, u64 val
836836
d = data + off - 1;
837837
d1 = data + words;
838838

839-
/* Process data forwards: */
840839
for (;;) {
841840
if (unlikely(d < data))
842841
d = data + words-1;
@@ -1733,12 +1732,12 @@ static int run_bench_numa(const char *name, const char **argv)
17331732
*/
17341733
static const char *tests[][MAX_ARGS] = {
17351734
/* Basic single-stream NUMA bandwidth measurements: */
1736-
{ "RAM-bw-local,", "mem", "-p", "1", "-t", "1", "-P", "1024",
1735+
{ "RAM-bw-local,", "mem", "-p", "1", "-t", "1", "-P", "1024",
17371736
"-C" , "0", "-M", "0", OPT_BW_RAM },
17381737
{ "RAM-bw-local-NOTHP,",
17391738
"mem", "-p", "1", "-t", "1", "-P", "1024",
17401739
"-C" , "0", "-M", "0", OPT_BW_RAM_NOTHP },
1741-
{ "RAM-bw-remote,", "mem", "-p", "1", "-t", "1", "-P", "1024",
1740+
{ "RAM-bw-remote,", "mem", "-p", "1", "-t", "1", "-P", "1024",
17421741
"-C" , "0", "-M", "1", OPT_BW_RAM },
17431742

17441743
/* 2-stream NUMA bandwidth measurements: */
@@ -1780,24 +1779,24 @@ static const char *tests[][MAX_ARGS] = {
17801779
"mem", "-p", "8", "-t", "1", "-P", " 512", OPT_BW_NOTHP },
17811780
{ "16x1-bw-process,", "mem", "-p", "16", "-t", "1", "-P", "256", OPT_BW },
17821781

1783-
{ " 4x1-bw-thread,", "mem", "-p", "1", "-t", "4", "-T", "256", OPT_BW },
1784-
{ " 8x1-bw-thread,", "mem", "-p", "1", "-t", "8", "-T", "256", OPT_BW },
1785-
{ "16x1-bw-thread,", "mem", "-p", "1", "-t", "16", "-T", "128", OPT_BW },
1786-
{ "32x1-bw-thread,", "mem", "-p", "1", "-t", "32", "-T", "64", OPT_BW },
1782+
{ " 1x4-bw-thread,", "mem", "-p", "1", "-t", "4", "-T", "256", OPT_BW },
1783+
{ " 1x8-bw-thread,", "mem", "-p", "1", "-t", "8", "-T", "256", OPT_BW },
1784+
{ "1x16-bw-thread,", "mem", "-p", "1", "-t", "16", "-T", "128", OPT_BW },
1785+
{ "1x32-bw-thread,", "mem", "-p", "1", "-t", "32", "-T", "64", OPT_BW },
17871786

1788-
{ " 2x3-bw-thread,", "mem", "-p", "2", "-t", "3", "-P", "512", OPT_BW },
1789-
{ " 4x4-bw-thread,", "mem", "-p", "4", "-t", "4", "-P", "512", OPT_BW },
1790-
{ " 4x6-bw-thread,", "mem", "-p", "4", "-t", "6", "-P", "512", OPT_BW },
1791-
{ " 4x8-bw-thread,", "mem", "-p", "4", "-t", "8", "-P", "512", OPT_BW },
1792-
{ " 4x8-bw-thread-NOTHP,",
1787+
{ " 2x3-bw-process,", "mem", "-p", "2", "-t", "3", "-P", "512", OPT_BW },
1788+
{ " 4x4-bw-process,", "mem", "-p", "4", "-t", "4", "-P", "512", OPT_BW },
1789+
{ " 4x6-bw-process,", "mem", "-p", "4", "-t", "6", "-P", "512", OPT_BW },
1790+
{ " 4x8-bw-process,", "mem", "-p", "4", "-t", "8", "-P", "512", OPT_BW },
1791+
{ " 4x8-bw-process-NOTHP,",
17931792
"mem", "-p", "4", "-t", "8", "-P", "512", OPT_BW_NOTHP },
1794-
{ " 3x3-bw-thread,", "mem", "-p", "3", "-t", "3", "-P", "512", OPT_BW },
1795-
{ " 5x5-bw-thread,", "mem", "-p", "5", "-t", "5", "-P", "512", OPT_BW },
1793+
{ " 3x3-bw-process,", "mem", "-p", "3", "-t", "3", "-P", "512", OPT_BW },
1794+
{ " 5x5-bw-process,", "mem", "-p", "5", "-t", "5", "-P", "512", OPT_BW },
17961795

1797-
{ "2x16-bw-thread,", "mem", "-p", "2", "-t", "16", "-P", "512", OPT_BW },
1798-
{ "1x32-bw-thread,", "mem", "-p", "1", "-t", "32", "-P", "2048", OPT_BW },
1796+
{ "2x16-bw-process,", "mem", "-p", "2", "-t", "16", "-P", "512", OPT_BW },
1797+
{ "1x32-bw-process,", "mem", "-p", "1", "-t", "32", "-P", "2048", OPT_BW },
17991798

1800-
{ "numa02-bw,", "mem", "-p", "1", "-t", "32", "-T", "32", OPT_BW },
1799+
{ "numa02-bw,", "mem", "-p", "1", "-t", "32", "-T", "32", OPT_BW },
18011800
{ "numa02-bw-NOTHP,", "mem", "-p", "1", "-t", "32", "-T", "32", OPT_BW_NOTHP },
18021801
{ "numa01-bw-thread,", "mem", "-p", "2", "-t", "16", "-T", "192", OPT_BW },
18031802
{ "numa01-bw-thread-NOTHP,",

0 commit comments

Comments
 (0)