Skip to content

Commit baecc47

Browse files
committed
PCI / PM: Skip bridges in pci_enable_wake()
PCI bridges only have a reason to generate wakeup signals on behalf of devices below them, so avoid preparing bridges for wakeup directly in pci_enable_wake(). Also drop the pci_has_subordinate() check from pci_pm_default_resume() as this will be done by pci_enable_wake() itself now. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
1 parent 16f73eb commit baecc47

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

drivers/pci/pci-driver.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -647,9 +647,7 @@ static int pci_legacy_resume(struct device *dev)
647647
static void pci_pm_default_resume(struct pci_dev *pci_dev)
648648
{
649649
pci_fixup_device(pci_fixup_resume, pci_dev);
650-
651-
if (!pci_has_subordinate(pci_dev))
652-
pci_enable_wake(pci_dev, PCI_D0, false);
650+
pci_enable_wake(pci_dev, PCI_D0, false);
653651
}
654652

655653
static void pci_pm_default_suspend(struct pci_dev *pci_dev)

drivers/pci/pci.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1912,6 +1912,13 @@ int pci_enable_wake(struct pci_dev *dev, pci_power_t state, bool enable)
19121912
{
19131913
int ret = 0;
19141914

1915+
/*
1916+
* Bridges can only signal wakeup on behalf of subordinate devices,
1917+
* but that is set up elsewhere, so skip them.
1918+
*/
1919+
if (pci_has_subordinate(dev))
1920+
return 0;
1921+
19151922
/* Don't do the same thing twice in a row for one device. */
19161923
if (!!enable == !!dev->wakeup_prepared)
19171924
return 0;

0 commit comments

Comments
 (0)