Merge estat with main repo (#4)

Author: prashks

Diff for: estat/README.md renamed to README_estat.md

@@ -2,7 +2,7 @@
 
 `estat` - extensible performance observability tool for Delphix Dynamic Data Platform.  
 
-This tool mainly uses `eBPF` programs with `BCC` front-end to collect and output performance statistics from kernel via `kprobes`.  
+This tool mainly uses `eBPF` programs with a `BCC` front-end to collect and output performance statistics from the kernel via `kprobes`.  
 It is made up of the following components:
 
 - `cmd/estat`
@@ -16,7 +16,7 @@ It is made up of the following components:
 
 ## Installation
 
-`estat` is provided as an archive package of its components.
+`estat` is already installed on the Delphix Dynamic Data Platform.
 
 ## Usage
 

Diff for: bpf/estat/backend-io.c

@@ -0,0 +1,83 @@
+/*
+ * Copyright 2019 Delphix. All rights reserved.
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+#include <uapi/linux/ptrace.h>
+#include <linux/bpf_common.h>
+#include <linux/blkdev.h>
+#include <linux/blk_types.h>
+#include <uapi/linux/bpf.h>
+
+
+// Definitions for this script
+#define	READ_STR "read "
+#define	WRITE_STR "write "
+#define	OP_NAME_LEN 7
+#define	DEV_NAME_LEN 8
+#define	NAME_LENGTH (OP_NAME_LEN + 1)
+#define	AXIS_LENGTH (DEV_NAME_LEN + 1)
+
+// Structure to hold thread local data
+typedef struct {
+	u64 ts;
+	unsigned int size;
+	unsigned int cmd_flags;
+	u32 err;
+	char device[DEV_NAME_LEN];
+} io_data_t;
+
+BPF_HASH(io_base_data, u64, io_data_t);
+
+// @@ kprobe|blk_start_request|disk_io_start
+// @@ kprobe|blk_mq_start_request|disk_io_start
+int
+disk_io_start(struct pt_regs *ctx, struct request *reqp)
+{
+	io_data_t data = {};
+	struct gendisk *diskp = reqp->rq_disk;
+	data.ts = bpf_ktime_get_ns();
+	data.cmd_flags = reqp->cmd_flags;
+	data.size = reqp->__data_len;
+	__builtin_memcpy(&data.device, diskp->disk_name, DEV_NAME_LEN);
+	io_base_data.update((u64 *) &reqp, &data);
+	return (0);
+}
+
+// @@ kprobe|blk_account_io_completion|disk_io_done
+int
+disk_io_done(struct pt_regs *ctx, struct request *reqp)
+{
+	u64 ts = bpf_ktime_get_ns();
+	io_data_t *data = io_base_data.lookup((u64 *) &reqp);
+	struct bio *bp = reqp->bio;
+
+	if (data == 0) {
+		return (0);   // missed issue
+	}
+
+	u64 delta = ts - data->ts;
+	char name[NAME_LENGTH] = "";
+	char axis[AXIS_LENGTH] = "";
+
+	data->err = (bp->bi_status == BLK_STS_OK) ? 0 : 1;
+
+	if ((data->cmd_flags & REQ_OP_MASK) == REQ_OP_WRITE) {
+		__builtin_memcpy(&name, WRITE_STR, OP_NAME_LEN);
+	} else {
+		__builtin_memcpy(&name, READ_STR, OP_NAME_LEN);
+	}
+
+#ifdef OPTARG
+	if ((sizeof (OPTARG) == 4) && (OPTARG[0] == 'l') &&
+	    (OPTARG[1] == 'u') && (OPTARG[2] == 'n')) {
+		__builtin_memcpy(&axis, data->device, AXIS_LENGTH);
+	}
+#endif
+
+	// Perform aggregations
+	AGGREGATE_DATA(name, axis, delta, data->size);
+	io_base_data.delete((u64 *) &reqp);
+	return (0);
+}

Diff for: bpf/estat/iscsi.c

@@ -0,0 +1,78 @@
+/*
+ * Copyright 2019 Delphix. All rights reserved.
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+#include <uapi/linux/ptrace.h>
+#include <linux/bpf_common.h>
+#include <uapi/linux/bpf.h>
+#include "target/iscsi/iscsi_target_core.h"
+
+
+// Definitions for this script
+#define	READ_STR "read"
+#define	WRITE_STR "write"
+
+#define	OP_NAME_LEN 6
+#define	NAME_LENGTH (OP_NAME_LEN + 1)
+
+typedef struct {
+	u64 ts;
+	u64 flags;
+	u64 size;
+} iscsi_data_t;
+
+
+BPF_HASH(iscsi_base_data, u64, iscsi_data_t);
+
+// @@ kprobe|iscsit_process_scsi_cmd|iscsi_target_start
+int
+iscsi_target_start(struct pt_regs *ctx, struct iscsi_conn *conn,
+    struct iscsi_cmd *cmd, struct iscsi_scsi_req *hdr)
+{
+	iscsi_data_t data = {};
+	data.ts = bpf_ktime_get_ns();
+	data.flags = hdr->flags;
+	data.size = hdr->data_length;
+	iscsi_base_data.update((u64 *) &cmd, &data);
+
+	return (0);
+}
+
+static int
+aggregate_data(iscsi_data_t *data, u64 ts, char *opstr)
+{
+	u64 delta;
+	char name[NAME_LENGTH] = "";
+	char axis = 0;
+
+	delta = ts - data->ts;
+	__builtin_memcpy(&name, opstr, OP_NAME_LEN);
+
+	// Perform aggregations
+	AGGREGATE_DATA(name, &axis, delta, data->size);
+	return (0);
+}
+
+// @@ kprobe|iscsit_build_rsp_pdu|iscsi_target_end
+int
+iscsi_target_end(struct pt_regs *ctx, struct iscsi_cmd *cmd)
+{
+	u64 ts = bpf_ktime_get_ns();
+	iscsi_data_t *data = iscsi_base_data.lookup((u64 *) &cmd);
+	u64 delta;
+
+	if (data == 0) {
+		return (0);   // missed issue
+	}
+
+	if (data->flags & ISCSI_FLAG_CMD_READ) {
+		aggregate_data(data, ts, READ_STR);
+	} else if (data->flags & ISCSI_FLAG_CMD_WRITE) {
+		aggregate_data(data, ts, WRITE_STR);
+	}
+	iscsi_base_data.delete((u64 *) &cmd);
+
+	return (0);
+}