You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
robert on delta-rs: normalize types, add struct literals back (lost them at some point). we can create a struct column but if you need to say "here are stats for file" that's struct literal that we don't support. lost this in expressions early on.
ryan: quesion - what if we want to just unpack as a bunch of literals? is that easier or harder for an engine to use? delta-rs use case is using to create partition values in add actions.
discussion about what to do about cbindgen? use slightly less optimal header for now? yes.
context: in new handle PR we have a transparent struct Handle which allows us to attach functionality and prevents raw pointer stuff from being available. (i.e. disallow pointer usage and only our interface) - bindgen makes this typedef correctly.
right now you can say const SharedSnapshot * and you will match typedef - TLDR we don't have to use typedef (it's an alias)
place it matters: if we want nullable handle.
cbindgen breaks down for nullable handle.
current state: annoying but harmless
add support for transparent typedef in cbindgen: todo link
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
summary
duckdb repo public! lots of PRs. ryan contributing to cbindgen.
action items
PRs in flight:
attendees
@nicklan @zachschuermann @hntd187 @scovich @roeap
notes stream
Handle
which allows us to attach functionality and prevents raw pointer stuff from being available. (i.e. disallow pointer usage and only our interface) - bindgen makes this typedef correctly.const SharedSnapshot *
and you will match typedef - TLDR we don't have to use typedef (it's an alias)inspect-table
work? some copypasta.Beta Was this translation helpful? Give feedback.
All reactions