Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write unit test(s) for cleanup_expired_logs_for() #1773

Open
rtyler opened this issue Oct 26, 2023 · 6 comments
Open

Write unit test(s) for cleanup_expired_logs_for() #1773

rtyler opened this issue Oct 26, 2023 · 6 comments
Assignees
@brayanjuls
Labels
binding/rust Issues for the Rust crate enhancement New feature or request good first issue Good for newcomers
Milestone
Rust v1.0.0

Comments

@rtyler
Copy link
Member

rtyler commented Oct 26, 2023

Description

In checkpoints.rs the cleanup_expired_logs_for function could use at ;least one unit test. In order to implement it cleanly, I think we should have a FakeObjectStore type which we can feed mock ObjectMeta structs into to to allow for testing the invocation of the list and delete_stream invocations that the function makes.

Related Issue(s)
@rtyler rtyler added enhancement New feature or request good first issue Good for newcomers binding/rust Issues for the Rust crate labels Oct 26, 2023
@rtyler
Copy link
Member Author

rtyler commented Oct 26, 2023

@cmackenzie1 I'm leaving this here for posterity 😈

@brayanjuls
Copy link
Contributor

Hey! can I work on this issue?

@rtyler
Copy link
Member Author

rtyler commented Oct 27, 2023

Sure!

@MrPowers MrPowers assigned MrPowers and brayanjuls and unassigned MrPowers Oct 27, 2023
@MrPowers
Copy link
Collaborator

@brayanjuls - assigned it to you, thanks!

@rtyler rtyler added this to the Rust v0.18 milestone Feb 6, 2024
@asura-io
Copy link

@rtyler is this still needed? If so I can take a look at it, doesn't look like it was implemented.

@rtyler
Copy link
Member Author

rtyler commented Nov 26, 2024

@asura-io go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brayanjuls brayanjuls

Labels
binding/rust Issues for the Rust crate enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Rust v1.0.0
Development

No branches or pull requests
4 participants
@rtyler @MrPowers @asura-io @brayanjuls