Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to add deltalake git dependency to cargo.toml #1821

Closed
osawyerr opened this issue Nov 8, 2023 · 7 comments
Closed

Unable to add deltalake git dependency to cargo.toml #1821

osawyerr opened this issue Nov 8, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@osawyerr
Copy link

osawyerr commented Nov 8, 2023

Hi there,

This is a question rather than a bug but the invite for the slack channel invite link doesn't seem to work, so I cant ask questions there.

I'm trying to add the dependency for deltalake to my project so that it pulls from the latest version in git but I can't get it to work. I tried adding the line below to my cargo.toml but it doesn't seem to find it.

deltalake = { git = "https://github.com/delta-io/delta-rs"}

How can I directly point to the deltalake on git?
@osawyerr osawyerr added the enhancement New feature or request label Nov 8, 2023
@cmackenzie1
Copy link
Contributor

Which version of Rust are you using? You will have to use a more recent version that supports Cargo Workspaces.

rustc --version
cargo version

I tried just now with a new project using Rust 1.73 and it works. You can upgrade your version using rustup install stable

cargo build
    Updating git repository `https://github.com/delta-io/delta-rs`
remote: Enumerating objects: 1829, done.
remote: Counting objects: 100% (1374/1374), done.
remote: Compressing objects: 100% (437/437), done.
remote: Total 1829 (delta 1050), reused 1084 (delta 924), pack-reused 455
Receiving objects: 100% (1829/1829), 977.68 KiB | 33.71 MiB/s, done.
Resolving deltas: 100% (1203/1203), completed with 127 local objects.
From https://github.com/delta-io/delta-rs
 * [new ref]                    -> origin/HEAD
 * [new tag]         python-v0.10.2 -> python-v0.10.2
 * [new tag]         python-v0.11.0 -> python-v0.11.0
 * [new tag]         python-v0.12.0 -> python-v0.12.0
 * [new tag]         python-v0.13.0 -> python-v0.13.0
 * [new tag]         rust-v0.15.0   -> rust-v0.15.0
 * [new tag]         rust-v0.16.0   -> rust-v0.16.0
    Updating crates.io index
  Downloaded errno v0.3.6
  Downloaded getrandom v0.2.11
  Downloaded serde_derive v1.0.192
  Downloaded serde v1.0.192
  Downloaded 4 crates (178.5 KB) in 0.57s
   Compiling autocfg v1.1.0
   Compiling proc-macro2 v1.0.69
   Compiling unicode-ident v1.0.12
   Compiling libc v0.2.150
   Compiling cfg-if v1.0.0
   Compiling libm v0.2.8
   Compiling serde v1.0.192
   Compiling bytes v1.5.0
   Compiling once_cell v1.18.0
   Compiling version_check v0.9.4
   Compiling core-foundation-sys v0.8.4
   Compiling memchr v2.6.4
   Compiling static_assertions v1.1.0
   Compiling iana-time-zone v0.1.58
   Compiling hashbrown v0.14.2
   Compiling zerocopy v0.7.25
   Compiling lexical-util v0.8.5
   Compiling semver v1.0.20
   Compiling ahash v0.8.6
   Compiling num-traits v0.2.17
   Compiling num-integer v0.1.45
   Compiling num-bigint v0.4.4
   Compiling num-rational v0.4.1
   Compiling num-iter v0.1.43
   Compiling lexical-write-integer v0.8.5
   Compiling lexical-parse-integer v0.8.6
   Compiling futures-core v0.3.29
   Compiling syn v1.0.109
   Compiling lexical-parse-float v0.8.5
   Compiling lexical-write-float v0.8.5
   Compiling slab v0.4.9
   Compiling getrandom v0.2.11
   Compiling jobserver v0.1.27
   Compiling futures-channel v0.3.29
   Compiling cc v1.0.83
   Compiling futures-task v0.3.29
   Compiling pkg-config v0.3.27
   Compiling pin-project-lite v0.2.13
   Compiling lexical-core v0.8.5
   Compiling rustc_version v0.4.0
   Compiling quote v1.0.33
   Compiling lock_api v0.4.11
   Compiling parking_lot_core v0.9.9
   Compiling syn v2.0.39
   Compiling futures-util v0.3.29
   Compiling futures-sink v0.3.29
   Compiling tinyvec_macros v0.1.1
   Compiling tinyvec v1.6.0
   Compiling flatbuffers v23.5.26
   Compiling aho-corasick v1.1.2
   Compiling futures-io v0.3.29
   Compiling doc-comment v0.3.3
   Compiling regex-syntax v0.8.2
   Compiling scopeguard v1.2.0
   Compiling itoa v1.0.9
   Compiling smallvec v1.11.1
   Compiling zstd-sys v2.0.9+zstd.1.5.5
   Compiling pin-utils v0.1.0
   Compiling ryu v1.0.15
   Compiling lz4-sys v1.9.4
   Compiling num-complex v0.4.4
   Compiling half v2.3.1
   Compiling chrono v0.4.31
   Compiling unicode-normalization v0.1.22
   Compiling async-trait v0.1.74
   Compiling heck v0.4.1
   Compiling zstd-safe v6.0.6
   Compiling percent-encoding v2.3.0
   Compiling crc32fast v1.3.2
   Compiling alloc-no-stdlib v2.0.4
   Compiling serde_json v1.0.108
   Compiling unicode-bidi v0.3.13
   Compiling bitflags v1.3.2
   Compiling alloc-stdlib v0.2.2
   Compiling form_urlencoded v1.2.0
   Compiling idna v0.4.0
   Compiling parking_lot v0.12.1
   Compiling num_cpus v1.16.0
   Compiling csv-core v0.1.11
   Compiling regex-automata v0.4.3
   Compiling tracing-core v0.1.32
   Compiling snap v1.1.0
   Compiling byteorder v1.5.0
   Compiling num v0.4.1
   Compiling arrow-buffer v47.0.0
   Compiling adler v1.0.2
   Compiling either v1.9.0
   Compiling paste v1.0.14
   Compiling same-file v1.0.6
   Compiling equivalent v1.0.1
   Compiling walkdir v2.4.0
   Compiling indexmap v2.1.0
   Compiling itertools v0.11.0
   Compiling miniz_oxide v0.7.1
   Compiling url v2.4.1
   Compiling brotli-decompressor v2.5.1
   Compiling ordered-float v2.10.1
   Compiling rand_core v0.6.4
   Compiling thiserror v1.0.50
   Compiling lazy_static v1.4.0
   Compiling integer-encoding v3.0.4
   Compiling humantime v2.1.0
   Compiling ppv-lite86 v0.2.17
   Compiling regex-syntax v0.7.5
   Compiling thrift v0.17.0
   Compiling rand_chacha v0.3.1
   Compiling regex v1.10.2
   Compiling brotli v3.4.0
   Compiling flate2 v1.0.28
   Compiling twox-hash v1.6.3
   Compiling bytemuck v1.14.0
   Compiling retain_mut v0.1.7
   Compiling snafu-derive v0.7.5
   Compiling fix-hidden-lifetime-bug-proc_macros v0.2.5
   Compiling base64 v0.21.5
   Compiling seq-macro v0.3.5
   Compiling roaring v0.10.2
   Compiling rand v0.8.5
   Compiling errno v0.3.6
   Compiling z85 v3.0.5
   Compiling log v0.4.20
   Compiling serde_derive v1.0.192
   Compiling futures-macro v0.3.29
   Compiling tracing-attributes v0.1.27
   Compiling tokio-macros v2.1.0
   Compiling thiserror-impl v1.0.50
   Compiling tokio v1.33.0
   Compiling snafu v0.7.5
   Compiling fix-hidden-lifetime-bug v0.2.5
   Compiling tracing v0.1.40
   Compiling lz4 v1.24.0
   Compiling futures-executor v0.3.29
   Compiling futures v0.3.29
   Compiling object_store v0.7.1
   Compiling arrow-schema v47.0.0
   Compiling csv v1.3.0
   Compiling uuid v1.5.0
   Compiling arrow-data v47.0.0
   Compiling zstd v0.12.4
   Compiling arrow-array v47.0.0
   Compiling arrow-select v47.0.0
   Compiling arrow-arith v47.0.0
   Compiling arrow-row v47.0.0
   Compiling arrow-cast v47.0.0
   Compiling arrow-string v47.0.0
   Compiling arrow-ord v47.0.0
   Compiling arrow-ipc v47.0.0
   Compiling arrow-json v47.0.0
   Compiling arrow-csv v47.0.0
   Compiling arrow v47.0.0
   Compiling parquet v47.0.0
   Compiling deltalake-core v0.17.0 (https://github.com/delta-io/delta-rs#7090a126)
   Compiling deltalake v0.17.0 (https://github.com/delta-io/delta-rs#7090a126)
   Compiling deltalake-import-issue-1821 v0.1.0 (/Users/cole/github.com/cmackenzie1/deltalake-import-issue-1821)
    Finished dev [unoptimized + debuginfo] target(s) in 22.95s

@cmackenzie1
Copy link
Contributor

@rtyler @wjones127 does setting workspaces.package.rust-version make sense here? My understanding older versions of Rust just fail to recognize the project format entirely but it might help to make it more apparent that there is a minimum.

@osawyerr
Copy link
Author

osawyerr commented Nov 8, 2023 •
edited
Loading

@cmackenzie1 thanks. Upgraded my version of rust to 1.73 and it works now. I was originally on on 1.70.

As an aside, is the slack forum still active? The invite link doesn't seem to work.

@roeap
Copy link
Collaborator

roeap commented Nov 8, 2023

As an aside, is the slack forum still active? The invite link doesn't seem to work.

@dennyglee - anything you can do about this? :)

@dennyglee
Copy link
Collaborator

@roeap @osawyerr Thanks for the ping - the Slack link should be active again now. Please let me know if there are any issues, eh?!

@osawyerr
Copy link
Author

osawyerr commented Nov 9, 2023

@roeap @osawyerr Thanks for the ping - the Slack link should be active again now. Please let me know if there are any issues, eh?!

@dennyglee The link on the main github page is still showing

This link is no longer active. To join this workspace, you’ll need to ask the person who originally invited you for a new link.

Can you please paste the working link here?

@dennyglee dennyglee mentioned this issue Nov 9, 2023
Merged
@dennyglee
Copy link
Collaborator

dennyglee commented Nov 9, 2023 •
edited
Loading

Oh gotcha - thanks for the clarification @osawyerr - I just created #1833 to address this.

@roeap - could you review and merge if appropriate? Thanks!

Actually, it's merged now, so we should be good to go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dennyglee @osawyerr @cmackenzie1 @roeap