-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt the delta kernel types #2489
Comments
I noticed the types were incorrect in kernel for timestamps. Would be good to backport fixes from delta-rs into kernel, otherwise we will have to fix some bugs again ^^ |
@ion-elgreco we do indeed have some divergence 😱 How confident are you in our tests for timestamp support? 😄 |
We should definitely just fix those in kernel. @ion-elgreco , do you have links to the fixes by any chance? Or just the divergence so I can figure out what needs to change? I can probably figure it out but might be faster if you just point me at it. Thanks! |
@nicklan I fixed the decimal parsing to prevent decimals being parsed that are beyond 38 precision or scale, see here (https://github.com/delta-io/delta-rs/pull/2332/files): delta-rs/crates/core/src/kernel/models/schema.rs Lines 548 to 552 in 81593e9
and here: delta-rs/crates/core/src/kernel/models/schema.rs Lines 628 to 635 in 81593e9
Here for timestampNtz: delta-rs/crates/core/src/kernel/expressions/eval.rs Lines 49 to 51 in 81593e9
and some parsing of multiple formats here: https://github.com/delta-io/delta-rs/pull/2383/files#diff-8e1a60f799cd1ad29923ee75871099a19c15ddfc00bef4617d82bdc02cbe3198 |
take |
started work on this, we do require some updates on kernel first to be able to consume the types, but hoping that this will not be too invasive. |
What feels like long ago, @roeap imported some kernel types manually into the
kernel
module from the early work on delta-kernel-rs. Nowdelta_kernel
has been released with a 0.0.1 we can move to adopting those symbols and begin incrementally adopting functionality from the kernel.This issue is just about the types. I'm not expecting to pull any of the log replay or snapshot code in
The text was updated successfully, but these errors were encountered: