Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_spill_size incorrect default value #2794

Closed
mrjsj opened this issue Aug 19, 2024 · 1 comment · Fixed by #2795
Closed

max_spill_size incorrect default value #2794

mrjsj opened this issue Aug 19, 2024 · 1 comment · Fixed by #2795
Assignees
Labels
bug Something isn't working

Comments

@mrjsj
Copy link
Contributor

mrjsj commented Aug 19, 2024

Environment

Delta-rs version:
0.19.0

Binding:
Rust

Environment:

  • Cloud provider: N/A
  • OS: N/A
  • Other: N/A

Bug

What happened:
The default value in crates/core/src/operations/optimize.rs::OptimizeBuilder::max_spill_size should be 20 GB, but it's nearly the double, as it's set to 20 * 1024 * 1024 * 2014

What you expected to happen:
Should be: 20 * 1024 * 1024 * 1024

How to reproduce it:

More details:
I will create PR with fix

@mrjsj mrjsj added the bug Something isn't working label Aug 19, 2024
@mrjsj
Copy link
Contributor Author

mrjsj commented Aug 19, 2024

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant