-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DAT tests for Rust #863
Comments
@wjones127 is this still current? (If so) how would you like to see this completed? |
Yes, this is still current. We have these for the Python bindings, but not for Rust. For reference, here are the scripts for the Python tests: So we'd want something parallel to that. This could be based on the load operation, or perhaps the DataFusion TableProvider. It might be a bit challenging to write in Rust, since the tests need to be generated based on the contents of a directory. You can see the approach |
@wjones127 I have been playing around with it and it looks like a way around it might be to infer the folders from the version of the input delta table. The test could be put into a macro maybe? #[macro_export]
macro_rules! eg_dat_test {
($( $test_name:ident $test:literal),*) => {
$(
#[tokio::test]
async fn $test_name()->TestResult{
//some body
let root = Path::new("someroot");
let path = root.join(Path::new($test));
//etc etc....
Ok(())
}
)*
}
}
eg_dat_test!(
test_foo "bar",
test_ram "ram"
); |
Yes something like that may work. Feel free to create a draft PR for discussion. |
Cool. I have put in a draft. There are some parts missing but the idea seems to be working mostly |
Description
Data Acceptance tests should be done for the Rust Arrow reader.
See: https://github.com/delta-incubator/dat
Use Case
Related Issue(s)
The text was updated successfully, but these errors were encountered: