Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file_uris() to error if without_files was set #867

Closed
wjones127 opened this issue Oct 8, 2022 · 0 comments · Fixed by #2809
Closed

Change file_uris() to error if without_files was set #867

wjones127 opened this issue Oct 8, 2022 · 0 comments · Fixed by #2809
Assignees
Labels
enhancement New feature or request

Comments

@wjones127
Copy link
Collaborator

Description

You can instantiate a DeltaTable struct without loading the files to save memory. If you call .file_uris() on that table, it will return an empty iterator, which isn't quite correct. I fear this might lead to issues later, where we can't differentiate between an empty table and one that was loaded without files. Perhaps this should return an error instead?

Use Case

Related Issue(s)

Found while looking at #866.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants