Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Consolidate CDF TahoeFileIndex code paths #1127

Open
scottsand-db opened this issue May 12, 2022 · 1 comment
Open

[Feature Request] Consolidate CDF TahoeFileIndex code paths #1127

scottsand-db opened this issue May 12, 2022 · 1 comment
Assignees
@amirmor1
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@scottsand-db
Copy link
Collaborator

Feature request

Overview

This commit added 3 new TahoeFileIndex's for the Change Data Feed feature currently being developed for Delta Lake. These are: CdcAddFileIndex, TahoeChangeFileIndex, and TahoeRemoveFileIndex.

These three classes have lots of similar code paths + logic, and can be consolidated to a simpler abstract base class + children to reduce duplicate code.

Feel free to give them better class names, too.

Motivation

Clean up the code. Less code duplication. Better file and class names. Easier to maintain and debug in the future.

For more info on the Change Data Feed project for Delta Lake, see #1105.
@scottsand-db scottsand-db added enhancement New feature or request good first issue Good for newcomers labels May 12, 2022
@amirmor1
Copy link

Hi, here is a link for a small PR https://github.com/delta-io/delta/pull/1278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amirmor1 amirmor1

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amirmor1 @scottsand-db