Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move echobot into /var/lib/echobot #281

Merged
merged 2 commits into from
May 5, 2024
Merged

Move echobot into /var/lib/echobot #281

merged 2 commits into from
May 5, 2024

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented May 2, 2024

Fixes #256
Fixes #277

@link2xt link2xt force-pushed the link2xt/echobot-no-root branch 2 times, most recently from 239afac to b5649f3 Compare May 2, 2024 18:32
Copy link
Contributor

@hpk42 hpk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to generate and store the echbot password in its home dir. The ini file better not contains secrets.

@link2xt link2xt marked this pull request as ready for review May 4, 2024 15:34
@link2xt link2xt force-pushed the link2xt/echobot-no-root branch 2 times, most recently from 490318c to 0ef78c4 Compare May 4, 2024 15:41
@link2xt link2xt requested a review from missytake May 4, 2024 18:38
Copy link
Contributor

@missytake missytake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)


return True


def get_user_data(db, config: Config, user):
if user == f"echo@{config.mail_domain}":
return dict(
home=f"/home/vmail/mail/{config.mail_domain}/echo", uid="vmail", gid="vmail"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
home=f"/home/vmail/mail/{config.mail_domain}/echo", uid="vmail", gid="vmail"
home=f"/home/vmail/mail/{config.mail_domain}/echo@{config.mail_domain}", uid="vmail", gid="vmail"

Typically, the vmail directory would be /echo@nine.testrun.org, not /echo I think...

@link2xt link2xt force-pushed the link2xt/echobot-no-root branch from 0ef78c4 to b0a2491 Compare May 5, 2024 13:37
@link2xt link2xt merged commit e1b1a94 into main May 5, 2024
4 of 5 checks passed
Copy link
Contributor

@hpk42 hpk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating echo@staging.testrun.org doesn't work: Authentication Failed. Echobot is running as root in root
3 participants