beta23 crashes on oauth2

[r10s]

{Received DC_EVENT_CONFIGURE_PROGRESS(20 ‰)}
{Received DC_EVENT_CONFIGURE_PROGRESS(200 ‰)}
ThreadId(5) src/configure/mod.rs:451: checking internal provider-info for offline autoconfig
ThreadId(5) src/configure/mod.rs:478: no offline autoconfig found
ThreadId(5) src/configure/read_url.rs:12: Requesting URL https://autoconfig.gmail.com"/mail/config-v1.1.xml?emailaddress=%22susisorgilos%40gmail%2Ecom%22
thread 'reqwest-internal-sync-runtime' panicked at 'a parsed Url should always be a valid Uri: InvalidUri(InvalidUriChar)', src/libcore/result.rs:1165:5
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::panicking::default_hook::{{closure}}
   4: std::panicking::rust_panic_with_hook
   5: std::panicking::continue_panic_fmt
   6: rust_begin_unwind
   7: core::panicking::panic_fmt
   8: core::result::unwrap_failed
   9: <std::future::GenFuture<T> as core::future::future::Future>::poll
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
thread '<unnamed>' panicked at 'event loop thread panicked', /Users/bpetersen/.cargo/registry/src/github.com-1ecc6299db9ec823/reqwest-0.10.0/src/blocking/client.rs:748:5
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::panicking::default_hook::{{closure}}
   4: std::panicking::rust_panic_with_hook
   5: std::panicking::begin_panic
   6: reqwest::blocking::client::event_loop_panicked
   7: <std::future::GenFuture<T> as core::future::future::Future>::poll
   8: reqwest::blocking::request::RequestBuilder::send
   9: deltachat::configure::read_url::read_url
  10: deltachat::configure::auto_mozilla::moz_autoconfigure
  11: deltachat::configure::JobConfigureImap
  12: <core::iter::adapters::Map<I,F> as core::iter::traits::iterator::Iterator>::try_fold
  13: deltachat::job::job_perform
  14: deltachat::job::perform_inbox_jobs
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

[r10s]

the requested url

https://autoconfig.gmail.com"/mail/config-v1.1.xml?emailaddress=%22susisorgilos%40gmail%2Ecom%22

in fact looks weird. there is a bad quote between the domain and the path and also the %22 quotes around the address seems wrong.

EDIT: the email address in param.addr given to utf8_percent_encode() is already literally quoted (all tested with the repl tool, btw). this is wrong, but the real issue is probably the first quote.

[r10s]

k, i think i found the reason, the email address contains literally quotes, so part after the @ gets one quote as well.

maybe another issue is that the app crashes (the url is just a probe and would not work anyway - so errors here could just be ignored)

[link2xt]

seanmonstar/reqwest#668

[r10s]

seanmonstar/reqwest#668

interesting, thank you!

however, the quote should not come into the url at all :)